-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Provider Refactor] CloseAccountPage #29962
[Form Provider Refactor] CloseAccountPage #29962
Conversation
@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
After re-focus manually email field - cursor disappears and i could not add/remove email Screen.Recording.2023-10-20.at.13.39.23.mov |
@narefyev91, both issues should be fixed after the latest commit, there were some problems with inputRefs assignment in the refactored components.
first-fix.mov
second-fix.mov |
Hey @luacmartins! That PR is important, because the changes in FormProvider fixes a bug that can cause crashes in some already migrated components. |
Seems we missing sign commits from @cdOut and lint failed |
@cdOut issue with re-focus still exists - happened on mWEB IOS Screen.Recording.2023-10-20.at.18.41.35.mov |
ce27306
to
8111010
Compare
Reviewer Checklist
Screenshots/VideosWebweb.movweb-fix-crash.movMobile Web - Chromeandroid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
@cdOut any updates on mWeb issue with IOS? |
@narefyev91 I was helping @cdOut with the previous issue with errors being thrown, but I can't reproduce the one you've sent in #29962 (comment) On my side everything works fine: Screen.Recording.2023-10-23.at.13.57.02_H.265.mp4 |
@narefyev91 I tried reproducing the bug you presented but I was only able to remake it once and it started working again after refocusing on the input field so it didn't permanently block the flow, unlike what you've shown in your case. As presented in the video it works fine on my end, it does not block any flow and it might be an error caused by the IOS simulator on your end. edgecase-test.mov |
The issue happened when keyboard is not fully shown in emulator and after forcing it's up by shift+command+k - it will be reproduced - but i think it should not happened to normal behaviour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎀 👀 🎀 C+ reviewed
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.90-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.90-2 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.91-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀
|
Details
Changed the Form component into the new FormProvider component in CloseAccountPage
Fixed Issues
$ #28870
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
SAFARI.mov
MacOS: Desktop
DESKTOP.mov