-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524
[CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524
Conversation
@ishpaul777 Can you run |
Co-authored-by: Jasper Huang <jasperhuangg@gmail.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
@ishpaul777 please put the videos into the OP description. Were you able to test on Android? |
Android app is crashing when ever i click request money. Not able to test. Can you try? Screen.Recording.2023-10-13.at.6.39.40.AM.mov |
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ishpaul777 can you try running |
@jasperhuangg I tried already will try again |
Working on the review. |
🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪 |
Uploaded Videos @jasperhuangg, Sorry if this delayed because of my broken emulator. |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-12.at.8.38.50.PM.movMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…-attachements fixes: invalid file modal and delete option shown for setted IOU (cherry picked from commit 5b35a3c)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.3.83-10 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.85-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀
|
Details
Fixed Issues
$ #29452
#29475
PROPOSAL: #29452 (comment)
#29475 (comment)
Tests
Test steps for #29475
Test Steps for #29452
Offline tests
QA Steps
Test steps for #29475
Test Steps for #29452
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Videos for https://github.com//issues/29452
Android: Native
Combined video for both issues
Record_2023-10-13-08-51-01.mp4
Android: mWeb Chrome
14927e19-483e-41a7-9d73-c91672dbeb3f.MP4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-13.at.04.55.06.mp4
iOS: mWeb Safari
RPReplay_Final1697154411.MP4
MacOS: Chrome / Safari
Screen.Recording.2023-10-13.at.4.50.48.AM.mov
MacOS: Desktop
Screen.Recording.2023-10-13.at.4.50.48.AM.mov
Videos for https://github.com//issues/29475
Android: Native
Combined video for both issuesRecord_2023-10-13-08-51-01.mp4
Android: mWeb Chrome
f20d405a-5b08-4be4-9b19-ae9a4f86ad2c.MP4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-13.at.06.29.59.mp4
iOS: mWeb Safari
RPReplay_Final1697159814.MP4
MacOS: Chrome / Safari
Screen.Recording.2023-10-13.at.6.40.50.AM.mov
MacOS: Desktop
Screen.Recording.2023-10-13.at.6.12.26.AM.mov