Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added manifest to web to prompt app install in chrome #29491

Merged
merged 8 commits into from
Oct 23, 2023
Merged

added manifest to web to prompt app install in chrome #29491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e02245c
added manifest to web to prompt app install in chrome
rlinoz Oct 12, 2023
7647df6
Added svg icon to manifest.json instead of the png one
rlinoz Oct 13, 2023
ef6286d
reverting adding asset_statements since it should be used for another…
rlinoz Oct 13, 2023
89eae94
Merge remote-tracking branch 'origin' into rodrigo-prompt-install-mweb
rlinoz Oct 16, 2023
9b82c7f
running prettier because of failed PR
rlinoz Oct 17, 2023
e5bde73
Merge remote-tracking branch 'origin' into rodrigo-prompt-install-mweb
rlinoz Oct 17, 2023
f3e0c1a
Merge remote-tracking branch 'origin' into rodrigo-prompt-install-mweb
rlinoz Oct 20, 2023
2ca8853
using already added expensify icon
rlinoz Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/webpack/webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({
{from: 'web/favicon-unread.png'},
{from: 'web/og-preview-image.png'},
{from: 'web/apple-touch-icon.png'},
{from: 'assets/images/expensify-app-icon.svg'},
{from: 'web/manifest.json'},
{from: 'assets/css', to: 'css'},
{from: 'assets/fonts/web', to: 'fonts'},
{from: 'node_modules/react-pdf/dist/esm/Page/AnnotationLayer.css', to: 'css/AnnotationLayer.css'},
Expand Down
29 changes: 15 additions & 14 deletions web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,31 +94,31 @@
transition: transform var(--label-transition-duration);
}

@media screen and (min-width: 480px) {
.splash-logo > svg {
width: 104px;
height: 104px;
@media screen and (min-width: 480px) {
.splash-logo > svg {
width: 104px;
height: 104px;
}
}

@media screen and (max-width: 479px) {
.splash-logo > svg {
width: 52px;
height: 52px;
@media screen and (max-width: 479px) {
.splash-logo > svg {
width: 52px;
height: 52px;
}
}

#splash {
position: absolute;
position: absolute;
bottom: 0;
left: 0;
right: 0;
top: 0;
background-color: #061B09;
width: 100%;
height: 100%;
display: flex;
justify-content: center;
background-color: #061B09;
width: 100%;
height: 100%;
display: flex;
justify-content: center;
align-items: center;
transition-duration: 250ms;
transition-property: opacity;
Expand All @@ -131,6 +131,7 @@
<!-- polyfill.io is only needed on Web to support older browsers. It should not be loaded for desktop -->
<script src="https://polyfill.io/v3/polyfill.min.js?features=default%2CResizeObserver&flags=gated"></script>
<% } %>
<link rel="manifest" href="/manifest.json" />
</head>
<body>
<div style="position: absolute; top: 0; left: 0; right: 0; height: 30px;" data-drag-area="true"></div>
Expand Down
20 changes: 20 additions & 0 deletions web/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"short_name": "New Expensify",
"name": "New Expensify",
"icons": [
{
"src": "expensify-app-icon.svg",
"type": "image/svg+xml",
"sizes": "any"
}
],
"prefer_related_applications": true,
"related_applications": [
{
"platform": "play",
"id": "com.expensify.chat"
}
],
"start_url": ".",
"display": "standalone"
}
Loading