-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] [TS migration] Migrate 'useEnvironment.js' hook and 'withEnvironment.js' HOC #29284
[No QA] [TS migration] Migrate 'useEnvironment.js' hook and 'withEnvironment.js' HOC #29284
Conversation
@blazejkustra I've added updates, please take a look |
@jjcoffee can we move forward with this PR? |
@BartoszGrajdek Sure, reviewing today - sorry this dropped off my radar last week! |
Reviewer Checklist
Screenshots/VideosWebchrome-desktop-2023-10-23_17.37.18.mp4Mobile Web - Chromeandroid-chrome.mp4Mobile Web - Safariios-safari-2023-10-25_14.27.01.mp4Desktopmac-desktop-2023-10-23_17.38.56.mp4iOSios-native-2023-10-25_14.27.58.mp4Androidandroid-native.mp4 |
Having some iOS build issues, I'll have to complete tomorrow unfortunately! |
Unfortunately still having iOS issues today, I'll switch to a different provider tomorrow if I can't get it resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well & LGTM!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24946 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.92-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.93-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀
|
Details
[TS migration] Migrate 'useEnvironment.js' hook and 'withEnvironment.js' HOC
Fixed Issues
$ #24946
$ #24960
PROPOSAL: N/A
Tests
Make sure the app uses the right environment and environment identification is correct (env-specific app logos/images).
Offline tests
N/A
QA Steps
Make sure the app uses the right environment and environment identification is correct (env-specific app logos/images).
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop