Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Private notes page shows not found in offline mode #28461

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix: Private notes page shows not found in offline mode #28461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/PrivateNotes/PrivateNotesListPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ function PrivateNotesListPage({report, personalDetailsList, network, session}) {
const {translate} = useLocalize();

useEffect(() => {
if (network.isOffline) {
if (network.isOffline && report.isLoadingPrivateNotes) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused #30246 where the Not Found page shows instead of a skeleton loader, more details here.

return;
}
Report.getReportPrivateNote(report.reportID);
}, [report.reportID, network.isOffline]);
}, [report.reportID, network.isOffline, report.isLoadingPrivateNotes]);
Copy link
Contributor Author

@tienifr tienifr Oct 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ ⚠️ I spotted a regression that if isLoadingPrivateNotes is in the dependencies list, getReportPrivateNotes would be triggered continuously. I'll raise a fix PR ASAP to remove it. @narefyev91 @grgia


/**
* Gets the menu item for each workspace
Expand Down
Loading