Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim the value when going back on connect bank account #28305

Merged
merged 33 commits into from
Oct 13, 2023
Merged

Trim the value when going back on connect bank account #28305

merged 33 commits into from
Oct 13, 2023

Commits on Sep 27, 2023

  1. Trim the value when going back on connect bank account

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    183e3fe View commit details
    Browse the repository at this point in the history

  2. use draft if the default value is empty

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    99477df View commit details
    Browse the repository at this point in the history

  3. fix typo

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    04e7887 View commit details
    Browse the repository at this point in the history

  4. save value to draft after updating data successfully

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    161abe5 View commit details
    Browse the repository at this point in the history

  5. fix merge main

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    15ef37f View commit details
    Browse the repository at this point in the history

  6. fix jest

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    883db65 View commit details
    Browse the repository at this point in the history

  7. fix lint

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    10f72f8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into fix/25996

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0fa5251 View commit details
    Browse the repository at this point in the history

  9. add comment

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    4532a36 View commit details
    Browse the repository at this point in the history

  10. create a const for fields of the step

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    3c4be81 View commit details
    Browse the repository at this point in the history

  11. fix lint

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    936289c View commit details
    Browse the repository at this point in the history

  12. Merge branch 'fix/25996' of https://github.com/dukenv0307/App into fi… 

    …x/25996
    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    88fc114 View commit details
    Browse the repository at this point in the history

  13. reuse the const

    @dukenv0307
    dukenv0307 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    25c2366 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. revert const

    @dukenv0307
    dukenv0307 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6caa796 View commit details
    Browse the repository at this point in the history

  2. fix jest

    @dukenv0307
    dukenv0307 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    270eddf View commit details
    Browse the repository at this point in the history

  3. fix lint

    @dukenv0307
    dukenv0307 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    12f5f05 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. fix no update when clicking on go back

    @dukenv0307
    dukenv0307 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a58a10e View commit details
    Browse the repository at this point in the history

  2. don't call update when unnecessary

    @dukenv0307
    dukenv0307 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f2b02f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Merge branch 'main' into fix/25996

    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6139ff2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/25996' of https://github.com/dukenv0307/App into fi… 

    …x/25996
    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    96bf07d View commit details
    Browse the repository at this point in the history

  3. add default value for param

    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    0de5e86 View commit details
    Browse the repository at this point in the history

  4. add check for shouldUpdateDataToDraft

    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b4bfd76 View commit details
    Browse the repository at this point in the history

  5. rename variable

    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1c1dd14 View commit details
    Browse the repository at this point in the history

  6. fix lint

    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    401e05d View commit details
    Browse the repository at this point in the history

  7. remove unuse field

    @dukenv0307
    dukenv0307 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    cc35473 View commit details
    Browse the repository at this point in the history

  8. Update src/pages/ReimbursementAccount/ReimbursementAccountPage.js 

    Co-authored-by: Olly <ollywilks@googlemail.com>
    @dukenv0307 @Ollyws
    dukenv0307 and Ollyws authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    0314480 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. add description

    @dukenv0307
    dukenv0307 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    abb6b20 View commit details
    Browse the repository at this point in the history

  2. add more detail description

    @dukenv0307
    dukenv0307 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    bec41b8 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @dukenv0307
    dukenv0307 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    4e75345 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Update src/libs/actions/BankAccounts.js 

    Co-authored-by: Florent De'Neve <florent@expensify.com>
    @dukenv0307 @flodnv
    dukenv0307 and flodnv authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c0e74b9 View commit details
    Browse the repository at this point in the history

  2. rename the variable

    @dukenv0307
    dukenv0307 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0f48962 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Update src/pages/ReimbursementAccount/ReimbursementAccountPage.js 

    Co-authored-by: Florent De'Neve <florent@expensify.com>
    @dukenv0307 @flodnv
    dukenv0307 and flodnv authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8d692b0 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @dukenv0307
    dukenv0307 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    26e9552 View commit details
    Browse the repository at this point in the history