Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: arrow navigation in context menu #27877

Merged
merged 19 commits into from
Sep 22, 2023
Merged

feat: arrow navigation in context menu #27877

merged 19 commits into from
Sep 22, 2023

Commits on Sep 20, 2023

  1. feat: arrow navigation in context menu

    @samh-nl
    samh-nl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    cd7278f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/issue-23280

    @samh-nl
    samh-nl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    977d4f1 View commit details
    Browse the repository at this point in the history

  3. fix: use internal press handler on Enter

    @samh-nl
    samh-nl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fa0b8e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Update src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js 

    Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>
    @samh-nl @situchan
    samh-nl and situchan authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5869c6c View commit details
    Browse the repository at this point in the history

  2. Update src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js 

    Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>
    @samh-nl @situchan
    samh-nl and situchan authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e8d9442 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/issue-23280

    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    20a5415 View commit details
    Browse the repository at this point in the history

  4. Revert "Update src/pages/home/report/ContextMenu/BaseReportActionCont… 

    …extMenu.js"

This reverts commit e8d9442.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    18a9e81 View commit details
    Browse the repository at this point in the history

  5. Revert "Update src/pages/home/report/ContextMenu/BaseReportActionCont… 

    …extMenu.js"

This reverts commit 5869c6c.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    777ca93 View commit details
    Browse the repository at this point in the history

  6. Revert "fix: use internal press handler on Enter" 

    This reverts commit fa0b8e7.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0867e44 View commit details
    Browse the repository at this point in the history

  7. Revert "feat: arrow navigation in context menu" 

    This reverts commit cd7278f.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    fe46818 View commit details
    Browse the repository at this point in the history

  8. Revert "Revert "feat: arrow navigation in context menu"" 

    This reverts commit fe46818.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    85ceb1e View commit details
    Browse the repository at this point in the history

  9. Revert "Revert "fix: use internal press handler on Enter"" 

    This reverts commit 0867e44.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    32ac964 View commit details
    Browse the repository at this point in the history

  10. Revert "Revert "Update src/pages/home/report/ContextMenu/BaseReportAc… 

    …tionContextMenu.js""

This reverts commit 777ca93.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    56d0a92 View commit details
    Browse the repository at this point in the history

  11. Revert "Revert "Update src/pages/home/report/ContextMenu/BaseReportAc… 

    …tionContextMenu.js""

This reverts commit 18a9e81.
    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c70a374 View commit details
    Browse the repository at this point in the history

  12. fix: prevent propagation of enter

    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    10bb500 View commit details
    Browse the repository at this point in the history

  13. fix: stopPropagation if item is selected

    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6428b28 View commit details
    Browse the repository at this point in the history

  14. fix: check event is set

    @samh-nl
    samh-nl committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4d4fff3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Update src/components/ContextMenuItem.js 

    Co-authored-by: Francois Laithier <francois@expensify.com>
    @samh-nl @francoisl
    samh-nl and francoisl authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    82ed8fc View commit details
    Browse the repository at this point in the history

  2. style: isFocused

    @samh-nl
    samh-nl committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ea487db View commit details
    Browse the repository at this point in the history