Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Chat - Loader is shown on top of image even after image is loaded in attachment carousel #27751

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Fix: Chat - Loader is shown on top of image even after image is loaded in attachment carousel #27751

merged 7 commits into from
Sep 26, 2023

Commits on Sep 19, 2023

  1. fix(Expensify#26046): cache detecting logic moved to Image component. 

    Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
    @Krishna2323
    Krishna2323 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    64d17c1 View commit details
    Browse the repository at this point in the history

  2. fix(Expensify#26046): loader on top of carousel image. 

    Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
    @Krishna2323
    Krishna2323 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bef2289 View commit details
    Browse the repository at this point in the history

  3. fix: useEffect missing dependency warning. 

    Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
    @Krishna2323
    Krishna2323 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d3f8bd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Merge branch 'main' into krishna2323/issue/26046

    @Krishna2323
    Krishna2323 authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    653b55d View commit details
    Browse the repository at this point in the history

  2. fix: lint warning. 

    Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
    @Krishna2323
    Krishna2323 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e7d3272 View commit details
    Browse the repository at this point in the history

  3. fix: lint warning. 

    Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
    @Krishna2323
    Krishna2323 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    cfd9535 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. revert back changes. 

    Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>
    @Krishna2323
    Krishna2323 committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    6825040 View commit details
    Browse the repository at this point in the history