Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: revalidate upon input and refocus if error occurs" #25781

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Revert "fix: revalidate upon input and refocus if error occurs" #25781

merged 1 commit into from
Aug 23, 2023

Conversation

roryabraham
Copy link
Contributor

Reverts #23995

Straight revert

@roryabraham roryabraham requested a review from a team as a code owner August 23, 2023 16:07
@roryabraham roryabraham self-assigned this Aug 23, 2023
@melvin-bot melvin-bot bot requested review from hayata-suenaga and removed request for a team August 23, 2023 16:08
@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham
Copy link
Contributor Author

Straight revert so no checklists 🤠

@roryabraham roryabraham merged commit 43c6f11 into main Aug 23, 2023
10 of 12 checks passed
@roryabraham roryabraham deleted the revert-23995-fix/issue-21958 branch August 23, 2023 16:13
@melvin-bot melvin-bot bot added the Emergency label Aug 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@amyevans amyevans mentioned this pull request Aug 23, 2023
Closed
6 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham roryabraham mentioned this pull request Aug 23, 2023
Closed
OSBotify pushed a commit that referenced this pull request Aug 23, 2023
@roryabraham @OSBotify
Merge pull request #25781 from Expensify/revert-23995-fix/issue-21958
992d137 
Revert "fix: revalidate upon input and refocus if error occurs"

(cherry picked from commit 43c6f11)
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.56-20 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 28, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.58-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyevans amyevans amyevans approved these changes

@hayata-suenaga hayata-suenaga Awaiting requested review from hayata-suenaga

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @amyevans