-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Login field is focused when sign out in small screen devices #24026
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During testing this PR, I found that the prevProp and nextProp always different in beginning. I.e, in this case,
!prevIsVisible && props.isVisible
is always true in beginning, becauseprevIsVisible
is initialized withundefined
, then ifprops.isVisible
has value,!prevIsVisible && props.isVisible
is always true in beginning. To solve this issue, I think we have 2 options:Option 1: Always check an addition condition that prevIsVisible is not undefined as well before checking if prevIsVisible is different with props.isVisible.
Pros: We don't touch existing code => It's might not cause any breaking changes.
Cons: It might be our tech debt/code smell later.
Option 2: Fix this LOC, I think we should pass input value as a initialize value of
ref
.Pros: If we fix here, I think it will work properly/correctly in the future for checking previousProps and nextProps
Cons: It might cause breaking changes. We need to test all current places using it. I have tested a few of them:
Screen.Recording.2023-08-03.at.07.04.50.mp4
I could not test because I could not pass the fill in card number. I asked in slack here https://expensify.slack.com/archives/C01GTK53T8Q/p1691020958967959
Screen.Recording.2023-08-03.at.09.45.46.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with either.