Fix App show error when open unlink in Desktop App #23738

hoangzinh · 2023-07-27T15:35:57Z

Details

Fixed Issues

$ #19681
PROPOSAL: #19681 (comment)

Tests

On Web/mWeb

Add a secondary login account, and leave it unverified
Sign out and sign in to the secondary login account above
Click on Unlink button
Open email account, click on 'the validation link here' to unlink the account
Verify that the page shows "Secondary login successfull unlinked" message

On Desktop
Ensure you logged out Expensify account in Web browser

Add a secondary login account, and leave it unverified
Sign out and sign in to the secondary login account above
Click on Unlink button
Open email account in Web browser, click on 'the validation link here' to unlink the account
Verify that the link opened in Web browser and there is no prompt to open the link in Desktop
Verify that the Web browser shows "Secondary login successfull unlinked" message

On Native apps
Ensure you logged out Expensify account in Web browser

Add a secondary login account, and leave it unverified
Sign out and sign in to the secondary login account above
Click on Unlink button
Open email account, click on 'the validation link here' to unlink the account
Verify that the Native app shows "Secondary login successfull unlinked" message

Verify that no errors appear in the JS console

Offline tests

Can not test when offline

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-04.at.09.06.42.-.web.mp4

Mobile Web - Chrome

Screen.Recording.2023-07-27.at.23.04.03.-.android.chrome.mov

Mobile Web - Safari

Screen.Recording.2023-07-27.at.22.53.01.-.ios.safari.mov

Desktop

Screen.Recording.2023-07-27.at.22.48.17.-.desktop.mp4

iOS

Screen.Recording.2023-07-27.at.23.02.10.-.ios.mp4

Android

Screen.Recording.2023-07-27.at.23.05.56.-.android.mp4

melvin-bot · 2023-07-27T16:15:08Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-07-28T22:14:45Z

@hoangzinh I find the Desktop steps confusing.

Verify that the link opened in a Web browser and there is no prompt to open the link in the Desktop

We won't show open in the desktop prompt for the dev environment. Have you checked by removing the restriction does it still work?

Santhosh-Sellavel · 2023-07-28T22:23:33Z

src/ROUTES.js

+
+    ROUTES_REGEX: {
+        UNLINK_LOGIN: /\/u($|(\/\/*))/,
+    },


Is it okay to be here? I think its better to be on CONST

Thoughts @francoisl?

Yeah agreed. Looks like we even already have a REGEX object, which has a similar ROUTES sub-object here. That sounds like a good place to put this.

I updated PR to move this const to CONST

hoangzinh · 2023-07-28T22:34:23Z

@hoangzinh I find the Desktop steps confusing.

Verify that the link opened in a Web browser and there is no prompt to open the link in the Desktop

We won't show open in the desktop prompt for the dev environment. Have you checked by removing the restriction does it still work?

@Santhosh-Sellavel definitely I did. In my recording, I also tried to show it show the desktop prompt for the home url

Santhosh-Sellavel · 2023-07-31T20:57:10Z

Will get to this tomorrow, please get this done @hoangzinh

Santhosh-Sellavel · 2023-07-31T20:58:33Z

src/components/DeeplinkWrapper/index.website.js

+    // Function to detect if current route should open in Web only.
+    isUnsupportedDeeplinkRoute() {


Comment can be more user friendly

Do you have any suggestion @Santhosh-Sellavel I think current comment is clear to me.

Santhosh-Sellavel · 2023-08-02T01:02:07Z

Seems to be tested well, After clicking the link we are redirected to the home page with a success message, but the unlink page is shown for a while after opening the link for unlinking is it a problem?

i.e This page is shown for a while

cc: @hoangzinh @francoisl

hoangzinh · 2023-08-02T16:20:18Z

@Santhosh-Sellavel It's not good UX, I think. What is the expected behavior here?:

Option 1: Show full loading page
Option 2: Redirect to the Login page first, then call API unlink, then show error/success.

Santhosh-Sellavel · 2023-08-02T17:12:01Z

@francoisl @NikkiWines What can we do here?

francoisl · 2023-08-03T17:30:51Z

Some sort of loading indicator sounds best to me (whether full page or not). We already set isLoading: true for the Account key here when we make the API request, can we piggy-back on that to know that the unlinking is in progress?

Santhosh-Sellavel · 2023-08-03T17:42:59Z

src/components/DeeplinkWrapper/index.website.js

+    // A function to detect if current route should be opened in Web only.
+    isUnsupportedDeeplinkRoute() {
+        return _.some([CONST.REGEX.ROUTES.UNLINK_LOGIN], (unsupportRouteRegex) => {
+            const routeRegex = new RegExp(unsupportRouteRegex);
+            return routeRegex.test(window.location.pathname);
+        });
+    }


The method name looks sufficient. Instead, we could have a comment inside explaining why the unlink login path was added here. Thoughts?

cc: @hoangzinh @francoisl

(Personal preference) I don't mind the comment outside the function, even if the name sounds sufficient. But overall neutral, I'm ok if we keep it or remove it.

However, yes a comment inside explaining why the unlink route is there sounds like a good idea to me!

I added the comment inside this func. Please help me review it again. Thanks

hoangzinh · 2023-08-04T02:13:01Z

Some sort of loading indicator sounds best to me (whether full page or not). We already set isLoading: true for the Account key here when we make the API request, can we piggy-back on that to know that the unlinking is in progress?

@Santhosh-Sellavel @francoisl I just updated with the full page loading, as a simplest implement. Because if we go with not full page loading, we need to involve Designer/UX into and discuss where should we display loading indicator.

I also recorded this full page loading in the Web section of this PR description.

Santhosh-Sellavel · 2023-08-07T18:49:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Unlink.mov

Mobile Web - Chrome

Screen.Recording.2023-08-08.at.12.01.25.AM.mov

Mobile Web - Safari

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-08.at.00.13.57.mp4

Android

Screen.Recording.2023-08-10.at.8.14.58.AM.mov

Santhosh-Sellavel · 2023-08-07T18:53:20Z

Please resolve conflicts @hoangzinh!

Santhosh-Sellavel · 2023-08-08T19:50:42Z

bump @hoangzinh!

hoangzinh · 2023-08-09T10:53:34Z

@Santhosh-Sellavel sorry I was off yesterday. I just resolved conflict of this PR. Could you help to review it again? Thanks

Santhosh-Sellavel · 2023-08-10T02:29:01Z

src/components/DeeplinkWrapper/index.website.js

+    const isUnsupportedDeeplinkRoute = useMemo(
+        () =>
+            // According to the design, we don't support unlink in Desktop app https://github.com/Expensify/App/issues/19681#issuecomment-1610353099
+            _.some([CONST.REGEX.ROUTES.UNLINK_LOGIN], (unsupportRouteRegex) => {
+                const routeRegex = new RegExp(unsupportRouteRegex);
+                return routeRegex.test(window.location.pathname);
+            }),
+        [],
+    );


Why do we need to memorize this?

I think it's an expensive calculator (loop through array and do regex) so I prefer memo it to prevent it rerun every time the component re-render.

1 value in array I don't think its expensive. Let's just have a definition and use it.

I just updated the PR. Please help me review it again. Thanks

Santhosh-Sellavel

LGTM, thanks!

Santhosh-Sellavel · 2023-08-11T17:49:16Z

@francoisl bump!

francoisl

LGTM, thanks for pushing this through to the end.

OSBotify · 2023-08-11T22:31:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-14T20:04:04Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-14T21:04:20Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-17T02:54:56Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.54-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2024-03-11T22:00:06Z

src/pages/UnlinkLoginPage.js

+            return;
+        }
+
+        Navigation.navigate(ROUTES.HOME);


Hey, this line caused a bug - #36618

RCA is here.

hoangzinh added 4 commits July 27, 2023 22:28

Should not open unlink in desktop

625adbe

Fix unable to unlink due to translation error

9e7114f

Fix linter

870c013

Remove unused util

16feab4

hoangzinh marked this pull request as ready for review July 27, 2023 16:15

hoangzinh requested a review from a team as a code owner July 27, 2023 16:15

melvin-bot bot removed the request for review from a team July 27, 2023 16:15

melvin-bot bot requested a review from Santhosh-Sellavel July 27, 2023 16:15

hoangzinh mentioned this pull request Jul 27, 2023

[C+ Checklist Needs Completion] [$2000] Desktop - Secondary login successfully unlinked isn't displayed on Desktop App #19681

Closed

6 tasks

francoisl assigned hoangzinh Jul 28, 2023

francoisl self-requested a review July 28, 2023 20:49

Santhosh-Sellavel reviewed Jul 28, 2023

View reviewed changes

Santhosh-Sellavel reviewed Jul 31, 2023

View reviewed changes

Change the regex const to CONST

1e4cba6

Santhosh-Sellavel reviewed Aug 3, 2023

View reviewed changes

hoangzinh added 4 commits August 4, 2023 07:13

Merge branch 'main' into df/19681_2

361f9bb

Update comment why unlink is in the list

a1bf7f3

Show full screen loading until the request is completed

6f37650

Fix linter

2bcd9f5

hoangzinh added 4 commits August 9, 2023 17:32

Merge branch 'main' into df/19681_2

4e1067f

Fix merge conflict

3f35a3d

Fix linter

f9b8d0e

Group early exit conditions

d9586c9

Santhosh-Sellavel reviewed Aug 10, 2023

View reviewed changes

hoangzinh added 2 commits August 10, 2023 21:46

Revert using useMemo

befda6d

Refactor code

21f34cc

Santhosh-Sellavel approved these changes Aug 10, 2023

View reviewed changes

francoisl approved these changes Aug 11, 2023

View reviewed changes

francoisl merged commit 7aac7fa into Expensify:main Aug 11, 2023
12 of 13 checks passed

OSBotify mentioned this pull request Aug 14, 2023

Deploy Checklist: New Expensify 2023-08-14 #24550

Closed

49 tasks

rushatgabhane reviewed Mar 11, 2024

View reviewed changes

src/pages/UnlinkLoginPage.js

return;

}

Navigation.navigate(ROUTES.HOME);

Copy link

Member

rushatgabhane Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this line caused a bug - #36618

RCA is here.

rushatgabhane mentioned this pull request Mar 11, 2024

[HOLD for payment 2024-03-07] [$500] Unlink - A non-stopping spinner is displayed when unlinking secondary contact method #36618

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix App show error when open unlink in Desktop App #23738

Fix App show error when open unlink in Desktop App #23738

hoangzinh commented Jul 27, 2023 •

edited

Loading

melvin-bot bot commented Jul 27, 2023

Santhosh-Sellavel commented Jul 28, 2023

Santhosh-Sellavel Jul 28, 2023

francoisl Jul 31, 2023

hoangzinh Aug 1, 2023

hoangzinh commented Jul 28, 2023

Santhosh-Sellavel commented Jul 31, 2023

Santhosh-Sellavel Jul 31, 2023 •

edited

Loading

hoangzinh Aug 1, 2023

Santhosh-Sellavel commented Aug 2, 2023

hoangzinh commented Aug 2, 2023

Santhosh-Sellavel commented Aug 2, 2023

francoisl commented Aug 3, 2023

Santhosh-Sellavel Aug 3, 2023

francoisl Aug 3, 2023

hoangzinh Aug 4, 2023

hoangzinh commented Aug 4, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 7, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 7, 2023

Santhosh-Sellavel commented Aug 8, 2023

hoangzinh commented Aug 9, 2023

Santhosh-Sellavel Aug 10, 2023

hoangzinh Aug 10, 2023

Santhosh-Sellavel Aug 10, 2023

hoangzinh Aug 10, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

Santhosh-Sellavel commented Aug 11, 2023

francoisl left a comment

OSBotify commented Aug 11, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 17, 2023

rushatgabhane Mar 11, 2024

		// Function to detect if current route should open in Web only.
		isUnsupportedDeeplinkRoute() {

Fix App show error when open unlink in Desktop App #23738

Fix App show error when open unlink in Desktop App #23738

Conversation

hoangzinh commented Jul 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 27, 2023

Santhosh-Sellavel commented Jul 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Jul 28, 2023

Santhosh-Sellavel commented Jul 31, 2023

Santhosh-Sellavel Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Aug 2, 2023

hoangzinh commented Aug 2, 2023

Santhosh-Sellavel commented Aug 2, 2023

francoisl commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh commented Aug 4, 2023 • edited Loading

Santhosh-Sellavel commented Aug 7, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Aug 7, 2023

Santhosh-Sellavel commented Aug 8, 2023

hoangzinh commented Aug 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoangzinh Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Aug 11, 2023

francoisl left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 11, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 17, 2023

Choose a reason for hiding this comment

hoangzinh commented Jul 27, 2023 •

edited

Loading

Santhosh-Sellavel Jul 31, 2023 •

edited

Loading

hoangzinh commented Aug 4, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 7, 2023 •

edited

Loading

hoangzinh Aug 10, 2023 •

edited

Loading