Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize current user's personal details when personalDetailsList is non empty and they can't be found #2250

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 6, 2021

cc @Julesssss

Details

Since it's possible for a user to not have personal details set we need to provide an empty object as a fallback. In the cases where a user has a personalDetailsList but no own expensify_personalDetails bad things happen like what is linked in the issues.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/158699
Fixes #2247
Fixes #2253

Tests

  1. Create a new account and domain for that account and update the domain admin's personal details
  2. Invite a member to the domain and validate their account
  3. Without making any changes to personal details (e.g. first name, avatar, etc) sign into Expensify.cash as the invited user
  4. Verify they are able to access the settings page and update personal details
  5. Verify they are able to leave comments without errors appearing in the JS console.

Logging in on main:
Screen Shot 2021-04-06 at 2 00 50 PM

Logging in on this branch:
Screen Shot 2021-04-06 at 1 56 10 PM

QA Steps

  1. Create a new account and login verify settings and leaving comments works as expected.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-04-06 at 1 56 10 PM

Mobile Web

2021-04-06_16-45-45

Desktop

2021-04-06_16-47-09

iOS

2021-04-06_16-48-35

Android

2021-04-06_16-54-53

@marcaaron marcaaron requested a review from a team as a code owner April 6, 2021 23:58
@marcaaron marcaaron self-assigned this Apr 6, 2021
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team April 6, 2021 23:58
@marcaaron
Copy link
Contributor Author

There is one daily + a deploy blocker attached to this one 🚀

@Julesssss
Copy link
Contributor

Resolved the issue for my broken users 👍

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 3a83195 into master Apr 7, 2021
@Jag96 Jag96 deleted the marcaaron-fixPersonalDetailsCrash branch April 7, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants