-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: console error on click of connect online with plaid button #22473
fix: console error on click of connect online with plaid button #22473
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@Santhosh-Sellavel This is yours! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise Looks good, tests well!
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-09.at.11.29.49.PM.movDesktopScreen.Recording.2023-07-09.at.11.42.58.PM.moviOS & AndroidScreen.Recording.2023-07-09.at.11.30.58.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all yours @francoisl!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #22448 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple PR to remove useLocalize
and bring back withLocalize
LGTM 👍
just a question, why we cannot useLocalize
?
@francoisl I'll wait until you have a chance to review since you were assigned to the migration PR that caused the regression
We can do that too, but we need to remove |
@payal-lathidadiya Can you just do that, Sorry for the back and forth! |
Yes, as far as I know, using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All yours @francoisl!
np. updated and pushed. |
@Santhosh-Sellavel Post omitting withLocalizeProptypes from StepPropTypes, somehow ESLint is failing for rule onyx-props-must-have-default Not sure what's cause of this. any idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have to do ..._.omit(StepPropTypes, _.keys(withLocalizePropTypes)),
in components that use useLocalize
and StepProps?
Yeah, since Else, it will result in console below errors (ref #22448) |
Should we remove |
Yes we would remove @hayata-suenaga |
okay thanks for explaining I re-ran the lint job again by the way. it failed for some unknow reason |
@hayata-suenaga @Santhosh-Sellavel |
@francoisl On the other hand let's just do nothing here as it will be eventually removed. Thoughts.? Only 3 Pages left to refactor that uses |
That could be an option. Are those 3 refactors in progress already or still on hold? Also, to clarify, other that the console error, is this causing any crash or breaking anything at the moment? |
@francoisl for those components, migration and refactor is still on hold. Below is state of component which uses StepPropTypes and withLocalize HOC
Also, this isn't causing any crash or breaking anything at the moment. |
…ll has props reference from HOC
Ok thanks. If some of those refactors are still on hold without a clear estimate of when they'll be done, I'd say it's fine to keep using the |
let's use |
Once all components which uses And remove withLocalize HOC reference and replace use of @francoisl / @hayata-suenaga should we create a new backlog issue for this expected refactor requirement in migration epic. |
I think we already have got approvals. |
@allroundexperts please final approve this PR when you got a moment 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump @hayata-suenaga!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.42-5 🚀
|
@payal-lathidadiya We get console error in this step |
@kavimuru please share the console error. So we can decide on that! |
@Santhosh-Sellavel this is the video 22473.Web.mp4 |
@kavimuru I just checked, this exists in production as well; Screen.Recording.2023-07-19.at.7.51.36.PM.mov |
@kavimuru please a new issue that's not relevant here. |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.44-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀
|
Details
Fixed Issues
$ #22448
PROPOSAL: #21778 (comment)
Tests
Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android