Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep keyboard visible on iOS/Android after posting a comment #224

Merged
merged 4 commits into from
Aug 18, 2020

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 18, 2020

Fixes #184

Details

Adds functionality allowing the keyboard on iOS/Android to remain up after posting a comment. The fix here is to stop using onSubmitEditing which has inconsistent behavior for multiline text inputs cross-platform, and instead use a submit button. I've added some simple styles to have the submit button show next to the text input to get this working for testing, will look into styling it like the current report page later.

Tests

  1. Confirm you can send messages on iOS/Android/Web normally
  2. On iOS/Android, confirm the keyboard stays up after posting a comment
iOS Android Web
image image image

@Jag96 Jag96 self-assigned this Aug 18, 2020
},

chatItemComposeBox: {
backgroundColor: '#FFFFFF',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: could this be defined as a color variable?

@tgolen tgolen merged commit 20b72ae into master Aug 18, 2020
@tgolen tgolen deleted the joe-visible-keyboard branch August 18, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep keyboard open after posting a new comment on mobile
3 participants