Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Attachment Carousel State Management in AttachmentModal and ReportAttachments #22179

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Improve Attachment Carousel State Management in AttachmentModal and ReportAttachments #22179

merged 3 commits into from
Jul 7, 2023

Commits on Jul 4, 2023

  1. Add callback for attachment carousel change in AttachmentModal 

    - Added a new prop `onCarouselAttachmentChange` to `AttachmentModal` component that is called whenever the carousel attachment changes.
- This new prop is a function that is called with the current attachment object as its argument.
- Also, a corresponding function is passed in `ReportAttachments` to navigate to the respective route for each attachment whenever the carousel attachment changes.
    @kidroca
    kidroca committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    50713ad View commit details
    Browse the repository at this point in the history

  2. Fix: Update auth token requirement state on attachment carousel change 

    Details:
- Modified the `onNavigate` function in `AttachmentModal` component to set the state of `isAuthTokenRequired` depending on the attachment navigated to.
- This change allows the component to correctly update whether an auth token is required or not for each attachment in the carousel.
    @kidroca
    kidroca committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    badd84e View commit details
    Browse the repository at this point in the history

  3. Code style: reformat with prettier

    @kidroca
    kidroca committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    806734f View commit details
    Browse the repository at this point in the history