Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign in page styles #2192

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix sign in page styles #2192

merged 1 commit into from
Apr 1, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Apr 1, 2021

Details

There was an issue with rendering on Desktop Safari/iOS Web for any pages that used the sign in page styles where they wouldn't flex to cover the entire document body. This is due to how Apple's Webkit renders flex styles slightly differently from how Chrome/other browsers do.

I added flex: 1 to the sign-in page styles to fix this.

Fixed Issues

Expensify/Expensify#157816

Tests

  1. Navigate to the sign in page, verify it renders correctly (see screenshot).
  2. Navigate to the set password page, verify it renders correctly (see screenshot).

Tested On

  • Mobile Web
  • Desktop

Screenshots

Web

Screen Shot 2021-03-19 at 12 23 38 PM

Screen Shot 2021-03-23 at 8 02 28 PM

Mobile Web

Screen Shot 2021-04-05 at 8 43 16 AM

Screen Shot 2021-04-05 at 8 43 24 AM

@jasperhuangg jasperhuangg self-assigned this Apr 1, 2021
@jasperhuangg jasperhuangg requested a review from a team as a code owner April 1, 2021 03:54
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team April 1, 2021 03:54
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcaaron
Copy link
Contributor

Should we test on iOS and Android?

@marcaaron
Copy link
Contributor

Tested iOS looks pretty OK to me.

@marcaaron
Copy link
Contributor

Feel free to merge this one once it passes E2E

@jasperhuangg jasperhuangg merged commit c916575 into master Apr 1, 2021
@jasperhuangg jasperhuangg deleted the jasper-fixSigninPageStyles branch April 1, 2021 04:19
@isagoico
Copy link

isagoico commented Apr 1, 2021

Title:
mWeb - 1.0.11-0 - Chat - "Sign in" and "Set password" pages are missing image and text

Expected Result

"Sign in" and "Set Password" pages are shown as they are in the PR #2192

##Actual Result
"Sign in" and "Set Password" pages are missing an image and some text.

Action Performed

  1. Open https://staging.expensify.cash
  2. Enter an email without an Expensify account and click "Continue".
  3. Click the verification link in the email. (Convert the link to staging if necessary)

Platform

Issue confirmed in:

mWeb: ✔️

Build: 1.0.11-0

Notes/Images/Videos

@marcaaron
Copy link
Contributor

Hmm I think those screenshots are incorrect.

@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented Apr 5, 2021

Hi @isagoico!

I don't think this is actually an issue. My mistake! I uploaded the wrong screenshots in the OP and I've fixed it above.

Password form on production

Screen Shot 2021-04-05 at 8 37 53 AM

Set password page on production

Screen Shot 2021-04-05 at 8 38 25 AM

This PR was only intended to get rid of the faint grey area that you can see in the bottom half of the above screenshots. Let me know if this clarifies things!

cc @marcaaron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants