-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sign in page styles #2192
Fix sign in page styles #2192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Should we test on iOS and Android? |
Tested iOS looks pretty OK to me. |
Feel free to merge this one once it passes E2E |
Title: Expected Result"Sign in" and "Set Password" pages are shown as they are in the PR #2192 ##Actual Result Action Performed
PlatformIssue confirmed in: mWeb: ✔️ Build: 1.0.11-0 |
Hmm I think those screenshots are incorrect. |
Hi @isagoico! I don't think this is actually an issue. My mistake! I uploaded the wrong screenshots in the OP and I've fixed it above. Password form on productionSet password page on productionThis PR was only intended to get rid of the faint grey area that you can see in the bottom half of the above screenshots. Let me know if this clarifies things! cc @marcaaron |
Details
There was an issue with rendering on Desktop Safari/iOS Web for any pages that used the sign in page styles where they wouldn't flex to cover the entire document body. This is due to how Apple's Webkit renders flex styles slightly differently from how Chrome/other browsers do.
I added
flex: 1
to the sign-in page styles to fix this.Fixed Issues
Expensify/Expensify#157816
Tests
Tested On
Screenshots
Web
Mobile Web