Fix: Obsolete LayoutAnimation

[tienifr]

Details

The LayoutAnimation in ReportActionCompose is no longer needed thanks to #19933. This PR removes it.

Fixed Issues

$ #20552
PROPOSAL: #20552 (comment)

Tests

1. Login with any account
2. Go to any chat
3. Type in @ to toggle mention suggestions
4. Verify that no console error appears
   ======
5. Click on return button for multiples empty line
6. Dismiss the keyboard on click on outside
7. Verify that no console error appears
   ======
8. Type something
9. Press emoji picker button
10. Verify that no console error appears

• Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

1. Login with any account
2. Go to any chat
3. Type in @ to toggle mention suggestions
4. Verify that no console error appears
   ======
5. Click on return button for multiples empty line
6. Dismiss the keyboard on click on outside
7. Verify that no console error appears
   ======
8. Type something
9. Press emoji picker button
10. Verify that no console error appears

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.16-06-2023.12.37.45.webm

Mobile Web - Chrome

Screencast.from.16-06-2023.12.39.27.webm

Mobile Web - Safari

Screen.Recording.2023-06-16.at.21.22.30.mov

Desktop

Screen.Recording.2023-06-16.at.21.28.48.mov

iOS

Screen.Recording.2023-06-22.at.16.20.58.mov

Android

Screencast.from.16-06-2023.12.36.20.webm

[melvin-bot]

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[sobitneupane]

@tienifr Can you please merge main. App is crashing when I enter @

[sobitneupane]

@tienifr Can you please add steps from issue in Test.

1. Go to any chat
2. Click on return button for multiples empty line
3. Dismiss the keyboard on click on outside

Also

1. Go to any chat
2. Type something
3. Press emoji button

I can still reproduce the issue.

Screen.Recording.2023-06-23.at.12.02.24.mov

Also while testing on IOS please make sure to use the keyboard from IOS not hardware keyboard.

[sobitneupane]

Go to any chat
Type something
Press emoji button

I was able to reproduce the issue with above steps.

[tienifr]

@sobitneupane Ah, my mistake. I'll find the root cause

[sobitneupane]

@tienifr Any update?

[tienifr]

@sobitneupane sorry I haven't been able to find what went wrong, seems that it's deep in the react-native-reanimated library, let me spend some more time on it during the weekends and let you know.

[tienifr]

@sobitneupane After further investigation, this seems to be a known issue of react-native KeyboardAvoidingView, see here. Basically whenever KeyboardAvoidingView or Alert animate together, or with other components, like the emoji suggestions, it will show the warning. Since it's the problem with native components, I think for that specific scenario we should wait for the upstream fix in react-native itself.

Meanwhile the fix here works for the scenario mentioned in the Github issue so we can proceed with this first, and possibly create another issue to wait for the native component fix upstream.

[sobitneupane]

@tienifr Is there any open issue to handle it for KeyboardAvoidingView? The issue you linked has last update in 2018. We cannot rely on that issue.

[tienifr]

@sobitneupane I couldn't find any more recent issue relating to this same thing. There're a couple of similar issues reported before but it was also from a while ago.

[s77rt]

What is the status here?

[sobitneupane]

@s77rt The issue was not completely solved by the PR. So, we have decided to reopen the issue for proposals.

[ShogunFire]

Are you still going to merge this ? I think this would resolve this: #21540