Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Find solution to low resolution large images on Android, and the Canvas crash #20798

Merged
merged 161 commits into from
Aug 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
161 commits
Select commit Hold shift + click to select a range
44df7a7
wip new pager
terrysahaidak May 15, 2023
2c38af4
use Image component
terrysahaidak May 16, 2023
feb406c
wip
terrysahaidak May 17, 2023
df20c64
Merge remote-tracking branch 'upstream/main' into @terrysahaidak/atta…
terrysahaidak May 17, 2023
3e1b958
Merge remote-tracking branch 'upstream/main' into @terrysahaidak/atta…
terrysahaidak May 18, 2023
adebe70
Merge remote-tracking branch 'upstream/main' into @terrysahaidak/atta…
terrysahaidak May 25, 2023
f9ec025
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 15, 2023
39ea2a8
fix: prettier
Jun 15, 2023
24f13ac
use correct import
Jun 15, 2023
5866b79
add dimensions with scale
Jun 15, 2023
b7551a0
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 16, 2023
a80bf0e
prefer early return
Jun 16, 2023
e9b7c09
simplify AttachmentCarousel structure
Jun 16, 2023
f1c2acc
fix: wrong bindings
Jun 16, 2023
a45c8cf
fix: eslint warning
Jun 16, 2023
f51cd9f
fix: paging
Jun 16, 2023
0daf91f
forward PagerRef
Jun 16, 2023
8c70c5c
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 19, 2023
34b0913
fix: merge changes
Jun 19, 2023
b2f4f06
stop reversing the attachments on native in "AttachmentCarousel"
Jun 19, 2023
fd98376
only show pager if container is big enough
Jun 19, 2023
8308483
hide buttons on gesture
Jun 19, 2023
089a792
fix: minor issues
Jun 19, 2023
a8a3b5a
update comment
Jun 19, 2023
6275e90
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 21, 2023
1f86dbf
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 23, 2023
14abde1
fix: nothing shown
Jun 23, 2023
f2e61a5
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 27, 2023
2ca0239
add "activeSource" logic
Jun 27, 2023
110faef
fix: reversing attachments
Jun 27, 2023
62b6d7a
use container size measurements in carousel implementations
Jun 27, 2023
caea7f9
fix: panning for very tall images
Jun 27, 2023
5b5fd9b
refine swipe down gesture (currently not in use)
Jun 27, 2023
842252b
add propTypes
Jun 27, 2023
8180e82
add onClose callback to <AttachmentCarousel />
Jun 27, 2023
723203d
fix: null checking
Jun 27, 2023
2e13962
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 27, 2023
d80255a
wrap Pager in GestureHandlerRootView for android
Jun 27, 2023
6649703
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jun 28, 2023
9e7075e
fix: prop types
Jun 28, 2023
2bdd106
use styles from global stylesheet
Jun 28, 2023
7bbe039
move constants to top
Jun 28, 2023
8acdb55
update page scrolling
Jun 28, 2023
36b858e
fix paging
Jun 28, 2023
6995620
fix: attachment carousel on web
Jun 28, 2023
6504ebd
extract propTypes
Jun 28, 2023
9d65356
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 10, 2023
686d565
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 11, 2023
0458a9a
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 12, 2023
1bed5a2
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 13, 2023
ca208f2
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 14, 2023
4f19c0c
fix: lint error
Jul 14, 2023
3f5e584
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 16, 2023
a1fd5c2
feat: implement real size image rendering
Jul 17, 2023
2575c48
fix: resizing
Jul 17, 2023
efcab94
fix: typo
Jul 18, 2023
312d936
Fix: implement scaling of non active images and improve loading state
Jul 18, 2023
70f7688
simplify ImageTransformer
Jul 18, 2023
acb9ddf
fix: propTypes and extract itemExtractor from lightbox
Jul 18, 2023
8e308ae
simplify
Jul 18, 2023
1621dd0
move autoHideArrow logic to native
Jul 18, 2023
0013679
move initial arrow showing logic to native implementation
Jul 18, 2023
567c5f1
simplify Lightbox and add propTypes to ImageTransformer
Jul 18, 2023
80e5bee
extract more logic from AttachmentCarousel and improve propTypes and …
Jul 18, 2023
05bc979
add more propTypes
Jul 18, 2023
db3a98e
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 18, 2023
a530909
further simplify Lightbox
Jul 18, 2023
b87f796
omit updating the image dimensions if already set
Jul 18, 2023
d23c2cc
fix: further simplify Lightbox
Jul 18, 2023
b0046a1
fix: loading state never ending
Jul 18, 2023
7608579
improve state in AttachmentCarousel
Jul 18, 2023
ef0952d
fix: state
Jul 18, 2023
b6a8721
fix: image should not be "flippable"
Jul 18, 2023
975df22
remove log
Jul 18, 2023
77b4ea4
fix: on tap not working
Jul 18, 2023
be8bac1
fix: arrows
Jul 18, 2023
56d1d50
fix: flashing
Jul 18, 2023
a1599fa
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 19, 2023
4cc0b87
rename component
Jul 19, 2023
f44fff7
major re-structure
Jul 19, 2023
cad059e
fix: imports
Jul 19, 2023
38b2280
extract more propTypes
Jul 19, 2023
d58e3c9
add "isUsedInCarousel" prop
Jul 19, 2023
003268b
split up AttachmentCarouselPage logic
Jul 19, 2023
64046b9
add isAuthTokenRequired prop to carousel page
Jul 19, 2023
dd6e0d5
fix: imports
Jul 19, 2023
e70bfa0
fix: imports
Jul 19, 2023
c6d69eb
fix: invalid import
Jul 19, 2023
8ef1107
simplify propTypes and fix pdfs
Jul 19, 2023
2b7ac8f
extract pdf logic
Jul 19, 2023
bee4df3
simplify attachment initialization
Jul 19, 2023
a1d7c2c
improve web AttachmentCarouselView
Jul 19, 2023
e7e8538
simplify AttachmentCarousel logic
Jul 19, 2023
5d3bb95
fix: jsdoc and params
Jul 19, 2023
1b51448
remove log
Jul 19, 2023
160eeb9
extract arrow showing logic
Jul 19, 2023
02ebe8a
simplify
Jul 19, 2023
aece50f
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 19, 2023
c153b6b
last fixes
Jul 19, 2023
7358b4c
only disable arrows on tap on touchscreen devices
Jul 19, 2023
5814620
fix: remaining issues
Jul 19, 2023
6adf6ab
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 20, 2023
6571838
fix: AttachmentView issues propTypes
Jul 20, 2023
eff55e3
remove null check
Jul 20, 2023
263eb6a
fix: wrong import
Jul 20, 2023
fff9fa4
fix types and restructure
Jul 20, 2023
67ab085
remove unused prop for now
Jul 20, 2023
06fcc03
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 22, 2023
feda2e4
adapt min/max scales by initial image scale
Jul 22, 2023
d16e5a4
adjust double tap scale too
Jul 22, 2023
9fc3993
fix: wrong import
Jul 22, 2023
fdac91d
fix: use doubleTapScale
Jul 22, 2023
4e81df3
simplify scaling logic
Jul 22, 2023
ac753ae
remove file from propTypes
Jul 23, 2023
7e4b01b
Merge branch 'main' into @terrysahaidak/attachment-gallery
Jul 27, 2023
50ac1c1
fix: maxScale based on max imageScale
Jul 27, 2023
9e7a0d5
rename and simplify pinch gesture variables
Jul 27, 2023
ac1a79e
simplify zoomToCoordinates
Jul 27, 2023
5e6081f
pass both horizontal and vertical iamge scale to ImageTransformer
Jul 27, 2023
5b9b433
simplify variables
Jul 27, 2023
2e306cb
Merge branch 'main' into @terrysahaidak/attachment-gallery
Aug 1, 2023
da5aca7
disallow panning, when image has smaller width than canvas
Aug 1, 2023
2a190af
simplify zoomToCoordinates variables
Aug 1, 2023
8fdb989
remove old variable
Aug 1, 2023
c8244af
add comment about totalScale calculation
Aug 1, 2023
6c505f6
simplify ImageTransformer render structure
Aug 1, 2023
a99e8db
remove unused import
Aug 1, 2023
4874dd2
improve doubleTap zoom to fill
Aug 1, 2023
88695c7
improve max/min scales
Aug 1, 2023
ba5f0a6
fix: focal point on double tap to zoom
Aug 1, 2023
ec29a43
gray out date in MoneyRequestView
c3024 Jul 31, 2023
7e06d57
converted emojipickermenu native to functional component
shubham1206agra Jul 29, 2023
7f66387
small bug fix
shubham1206agra Jul 29, 2023
8e0678e
removed unecessary comment
shubham1206agra Jul 30, 2023
d90507e
prettier lint
shubham1206agra Jul 31, 2023
0db10d8
ReBump Reanimated to 3.4.0
shubham1206agra Jul 31, 2023
e162d75
updated for newer definition
shubham1206agra Jul 31, 2023
a787399
append current time to the downloaded file name
bernhardoj Jul 25, 2023
6d89f48
create unit test
bernhardoj Jul 25, 2023
ea964f4
update wording
bernhardoj Jul 25, 2023
b4a4773
prettier
bernhardoj Jul 25, 2023
b631544
add jsdoc
bernhardoj Jul 26, 2023
784b95c
rename function
bernhardoj Jul 26, 2023
7bf113e
make the date format consistent
bernhardoj Jul 27, 2023
c0bce39
remove spaces between hyphen
bernhardoj Jul 28, 2023
af08d4c
increase animation speed
Aug 1, 2023
dd18605
Merge branch 'main' into @terrysahaidak/attachment-gallery
Aug 1, 2023
848aff6
fix: arrows not showing on web
Aug 1, 2023
33c6261
add bounce effect
Aug 1, 2023
e7a3f2c
simplify code
Aug 1, 2023
5c02533
Merge branch 'main' into @terrysahaidak/attachment-gallery
Aug 1, 2023
5fc9e09
Merge branch 'main' into @terrysahaidak/attachment-gallery
Aug 2, 2023
ec358fa
fix: focal point not correct in image double tap
Aug 2, 2023
bd34474
remove log and fix doubleTapScale
Aug 2, 2023
c48f2fa
only show image after onLoadEnd is triggered
Aug 2, 2023
48c28f1
return undefined style instead of empty object
Aug 2, 2023
b2f4f3a
fix: initial page not stopping to load
Aug 2, 2023
7dd20ab
fix: initial load of first active page
Aug 2, 2023
b3ac3a1
fix: don't unmount next inactive pages
Aug 2, 2023
703a230
increase max zoom scale
Aug 2, 2023
f8386f8
Merge branch 'main' into @terrysahaidak/attachment-gallery
Aug 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import PropTypes from 'prop-types';
import {propTypes as anchorForAttachmentsOnlyPropTypes, defaultProps as anchorForAttachmentsOnlyDefaultProps} from './anchorForAttachmentsOnlyPropTypes';
import CONST from '../../CONST';
import ONYXKEYS from '../../ONYXKEYS';
import AttachmentView from '../AttachmentView';
import AttachmentView from '../Attachments/AttachmentView';
import * as Download from '../../libs/actions/Download';
import fileDownload from '../../libs/fileDownload';
import addEncryptedAuthTokenToURL from '../../libs/addEncryptedAuthTokenToURL';
Expand Down
67 changes: 0 additions & 67 deletions src/components/AttachmentCarousel/createInitialState.js

This file was deleted.

Loading
Loading