-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow edit by up key on thread parent message #20273
Allow edit by up key on thread parent message #20273
Conversation
@grgia @allroundexperts One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@grgia Should I add the TODO comment like we did here?
|
const lastReportAction = _.find(this.props.reportActions, (action) => ReportUtils.canEditReportAction(action)); | ||
const parentReportActionID = lodashGet(this.props.report, 'parentReportActionID', ''); | ||
const parentReportAction = lodashGet(this.props.parentReportActions, [parentReportActionID], {}); | ||
const lastReportAction = _.find([...this.props.reportActions, parentReportAction], (action) => ReportUtils.canEditReportAction(action)); | ||
|
||
if (lastReportAction !== -1 && lastReportAction) { | ||
Report.saveReportActionDraft(this.props.reportID, lastReportAction.reportActionID, _.last(lastReportAction.message).html); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernhardoj Editing the message does not show up immediately. I think the culprit is this line where we are supplying this.props.reportID
instead of the parentReportId
. We should fix this as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That also happens on main when you edit it through the pencil icon. I think I ever see that issue reported. If we use the parentReportID, the message that will enter the edit mode is the parent one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, there is an already ongoing issue for this. Let's just handle this there then.
@@ -833,7 +837,9 @@ class ReportActionCompose extends React.Component { | |||
) { | |||
e.preventDefault(); | |||
|
|||
const lastReportAction = _.find(this.props.reportActions, (action) => ReportUtils.canEditReportAction(action)); | |||
const parentReportActionID = lodashGet(this.props.report, 'parentReportActionID', ''); | |||
const parentReportAction = lodashGet(this.props.parentReportActions, [parentReportActionID], {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't you using the approach that you proposed? I think we can add a comment about the HoC along with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha!
@bernhardoj Can you resolve conflicts please? |
Ah, I thought it's another conflict, turns out I forget to push it. |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-06-08.at.1.01.17.AM.movDesktopScreen.Recording.2023-06-08.at.1.05.03.AM.mov |
@bernhardoj Can you add missing screenshots on mobile platforms? |
Added the screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @grgia All yours!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/grgia in version: 1.3.26-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀
|
Details
Currently, we can't edit thread parent message by arrow up key. This PR fix it.
Fixed Issues
$ #19781
PROPOSAL: #19781 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Web/Desktop
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-06-06.at.22.51.17.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
Screen.Recording.2023-06-06.at.22.53.52.mov
iOS
Android