-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17058 - migrate AvatarCropModal to PressableWithoutFeedback #20260
17058 - migrate AvatarCropModal to PressableWithoutFeedback #20260
Conversation
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I will be working on C+ review on this |
style={[styles.mh5, styles.flex1]} | ||
onLayout={initializeSliderContainer} | ||
onPressIn={(e) => runOnUI(sliderOnPress)(e.nativeEvent.locationX)} | ||
accessibilityLabel="slider" | ||
accessibilityRole="adjustable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are adding a CONST for accessibilityRole here - https://github.com/Expensify/App/pull/20251/files#diff-9d6b0cc89c7cab66ac4042ac0549bfc66ddc9e7a182b6b5dbbf7f687328f10b5R2451
We should incorporate these changes as well before we push
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulrahuman5196 I think there are some problems with merging PR that adds CONSTs. In other similar PRs we agreed create another PR that will change accessibilityLabels everywhere to use CONSTS, so we can try to merge this PR without it
@Skalakid Can you add "Same as test" in "Offline tests" and "QA Steps" sections? |
Reviewer Checklist
Screenshots/VideosWebUntitled.55.mp4Mobile Web - Chromeaz_recorder_20230617_231354.mp4Mobile Web - SafariUntitled.54.mp4DesktopUntitled.57.mp4iOSUntitled.56.mp4AndroidUntitled.58.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours @arosiclair
@Skalakid Kindly make sure to address this test update comment
@arosiclair Kindly check on this, pending on your review/approval |
bump @roryabraham if you want to review |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.31-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀
|
Details
Fixed Issues
$ #17058
PROPOSAL: #17058
Tests
Settings
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
N/A idk I can't enter this page :(
Mobile Web - Safari
mWeb-safari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov