Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20021 — migrate AddPayPalMePage #20045

Merged
merged 3 commits into from
Jun 9, 2023
Merged

20021 — migrate AddPayPalMePage #20045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a73893d
migrate AddPayPalMePage to PressableWithoutFeedback
robertKozik Jun 2, 2023
b703379
fix problem with genericPressable autoHitSlop when its false
robertKozik Jun 2, 2023
cf770db
Merge branch 'main' into 20021-migrate-AddPayPalMePage
robertKozik Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Pressable/GenericPressable/BaseGenericPressable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ const GenericPressable = forwardRef((props, ref) => {

return (
<Pressable
hitSlop={shouldUseAutoHitSlop && hitSlop}
hitSlop={shouldUseAutoHitSlop ? hitSlop : undefined}
onLayout={onLayout}
ref={ref}
onPress={!isDisabled ? onPressHandler : undefined}
Expand Down
12 changes: 7 additions & 5 deletions src/pages/settings/Payments/AddPayPalMePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, {useRef, useState, useCallback} from 'react';
// eslint-disable-next-line no-restricted-imports
import {View, TouchableWithoutFeedback, Linking} from 'react-native';
import {View, Linking} from 'react-native';
import _ from 'underscore';
import CONST from '../../../CONST';
import ROUTES from '../../../ROUTES';
Expand All @@ -20,6 +19,7 @@ import * as User from '../../../libs/actions/User';
import Icon from '../../../components/Icon';
import * as Expensicons from '../../../components/Icon/Expensicons';
import variables from '../../../styles/variables';
import PressableWithoutFeedback from '../../../components/Pressable/PressableWithoutFeedback';

const AddPayPalMePage = (props) => {
const [payPalMeUsername, setPayPalMeUsername] = useState('');
Expand Down Expand Up @@ -71,8 +71,10 @@ const AddPayPalMePage = (props) => {
/>
<View style={[styles.mt3, styles.flexRow, styles.justifyContentBetween, styles.alignSelfStart]}>
<Text style={[styles.textMicro, styles.flexRow]}>{props.translate('addPayPalMePage.checkListOf')}</Text>
<TouchableWithoutFeedback
// eslint-disable-next-line max-len
<PressableWithoutFeedback
shouldUseAutoHitSlop={false}
accessibilityRole="link"
accessibilityLabel={props.translate('addPayPalMePage.supportedCurrencies')}
onPress={() => Linking.openURL('https://developer.paypal.com/docs/reports/reference/paypal-supported-currencies')}
>
<View style={[styles.flexRow, styles.cursorPointer]}>
Expand All @@ -91,7 +93,7 @@ const AddPayPalMePage = (props) => {
/>
</View>
</View>
</TouchableWithoutFeedback>
</PressableWithoutFeedback>
</View>
</View>
</View>
Expand Down