-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crash when open report for anonymous user #19818
Conversation
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-05-30.at.10.41.42.movMobile Web - ChromeScreen.Recording.2023-05-30.at.10.48.52.movMobile Web - SafariScreen.Recording.2023-05-30.at.10.47.00.movDesktopN/A, I thought desktop was not working, but for some reason it's not working locally locally for anonymous users. Skipping this since it wasn't considered in the original PR but the PR author added a video that shows desktop working with the staging configuration. iOSiOS environment is broken locally for me. But given this is a deploy blocker fix and the changes are not platform specific I will skip this. AndroidScreen.Recording.2023-05-30.at.10.52.56.mov |
Please add the screenshots and complete the checklist when you have a moment. |
fix crash when open report for anonymous user (cherry picked from commit 00a771f)
…-19818 🍒 Cherry pick PR #19818 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/marcochavezf in version: 1.3.20-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.20-5 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
Details
@mountiny can you please review this?
Fixed Issues
$ #19823
$ Follow-up of #18293
PROPOSAL: https://expensify.slack.com/archives/C01GTK53T8Q/p1685453847588049?thread_ts=1685451659.037849&cid=C01GTK53T8Q
Tests
Same as Tests step in #18293
And verify that app doesn't crash from beginning to end.
Offline tests
Same as Offline tests in #18293
QA Steps
Same as Tests step
And verify that app doesn't crash from beginning to end.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mchrome.mov
Mobile Web - Safari
msafari.mov
Desktop
desktop.mov
iOS
Android