Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User_UploadAvatar to take in a file instead of a base64 image #1966

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

NikkiWines
Copy link
Contributor

@NikkiWines NikkiWines commented Mar 20, 2021

Held upon https://github.com/Expensify/Web-Expensify/pull/30517

Details

Updates User_Upload avatar so that it doesn't have to take in a base64 image string to work.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/156268

Tests

  1. Add a debug point here and open your JS Console
  2. In a chat, add an attachment and press Upload
  3. When the debug point is triggered run the following:
personalDetails = _PersonalDetails__WEBPACK_IMPORTED_MODULE_11__;
personalDetails.setAvatar(file)

and then continue execution
4. Wait a few seconds and confirm your profile picture is updated.
5. Refresh the page and confirm your user avatar is updated.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

cc: @marcaaron since we discussed this

@NikkiWines NikkiWines requested a review from a team as a code owner March 20, 2021 00:05
@NikkiWines NikkiWines self-assigned this Mar 20, 2021
@botify botify requested review from thienlnam and removed request for a team March 20, 2021 00:05
@NikkiWines NikkiWines changed the title Update User_UploadAvatar to take in a file instead of a base64 image [HOLD] Update User_UploadAvatar to take in a file instead of a base64 image Mar 20, 2021
@NikkiWines NikkiWines changed the title [HOLD] Update User_UploadAvatar to take in a file instead of a base64 image Update User_UploadAvatar to take in a file instead of a base64 image Mar 24, 2021
@NikkiWines
Copy link
Contributor Author

off hold now that https://github.com/Expensify/Web-Expensify/pull/30517 has been deployed to prod!

@thienlnam thienlnam merged commit 6febd9a into master Mar 24, 2021
@thienlnam thienlnam deleted the nikki-cash-avatar-file branch March 24, 2021 20:48
@isagoico
Copy link

@NikkiWines Hello! This one looks like internal QA. If so, can you let me know when it's QAd so I can check it off? Thanks in advance!

@NikkiWines
Copy link
Contributor Author

@isagoico Ah I don't think this can be QA'd at all, sorry! Forgot we added staging to E.cash now

@isagoico
Copy link

No worries at all! Thanks for the quick answer. Checking it off as No QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants