-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old single pusher events #18752
Conversation
This is on HOLD for a web-e dependency, but please review it so that it is ready to merge once the HOLD is removed. |
@0xmiroslav @joelbettner One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -566,7 +566,7 @@ function triggerNotifications(onyxUpdates) { | |||
* Handles the newest events from Pusher where a single mega multipleEvents contains | |||
* an array of singular events all in one event | |||
*/ | |||
function subscribeToUserEventsUsingMultipleEventType() { | |||
function subscribeToUserEvents() { | |||
// Handles the mega multipleEvents from Pusher which contains an array of single events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// If we don't have the user's accountID yet we can't subscribe so return early
if (!currentUserAccountID) {
return;
}
Should we early return if currentUserAccountID
not exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's add that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, hahaha, I thought it was still there in the code. I didn't realize I had removed it, so I was a little confused about your first question :D I'll add it back in
Unit Tests failing |
Updated |
code looks good. just waiting for backend PR to hit staging or production |
@iwiznia This is the final cleanup for the unified pusher events once https://github.com/Expensify/Web-Expensify/pull/37560 is in production. I'm handing the PR over to you since I will be on sabbatical when it's time to merge it. |
This is ready to review |
@0xmiroslav give me a bump when you've been able to run the checklist for this. |
will do in a few hrs |
@0xmiroslav gentle bump. |
@0xmiroslav bump |
Sorry missed this. Will checklist today |
Was 1 second away from pinging you @0xmiroslav |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-13.at.3.47.23.PM.movMobile Web - ChromeMobile Web - SafariDesktopiOSScreen.Recording.2023-07-13.at.3.52.20.PM.movAndroid |
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.41-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.42-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀
|
@tgolen can you please create payment GH for me? |
I am not sure how to do that exactly, but maybe @dylanexpensify could help us out with that? He's very handy with these sorts of things. |
@dylanexpensify friendly bump ^ |
Hello!! Yes can help! @0xmiroslav I'll send you a link tomorrow!!! |
@dylanexpensify bump in case you missed 🙂 |
multipleEvents
event typeFixed Issues
$ https://github.com/Expensify/Expensify/issues/279347
Tests
Offline tests
None (pusher events don't work when you're offline)
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
I'm having issues signing in with IOS currently, so this screenshot will need to be added later
Android