-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show transaction amount & description in report header for "transaction thread" #18695
Merged
Merged
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6cc8fc0
add isMoneyRequestThreadReport
marcaaron f407caa
render MoneyRequestHeader when it is a MoneyRequestReport or MoneyReq…
marcaaron 318d497
Fix rightside of ||
marcaaron 366ca0f
Call the method once
marcaaron 071181f
Add some stuff to alert us if the parent report does not exist for th…
marcaaron 6a49029
Fix conflicts and update names to make a bit more sense
marcaaron 0fd45aa
Merge branch 'main' into marcaaron-isMoneyRequestThreadReport
marcaaron fda42d5
put a comma back in
marcaaron 358d75e
Render reportaction rows in MoneyRequestHeader
marcaaron ade391a
Add new kansas font style
marcaaron 91aac1e
Merge branch 'main' into marcaaron-isMoneyRequestThreadReport
marcaaron d5ad0f3
Get parentReport via Onyx to populate header avatars/names
marcaaron 5ace3d4
Merge branch 'main' into marcaaron-isMoneyRequestThreadReport
Julesssss bc14485
Merge branch 'main' into marcaaron-isMoneyRequestThreadReport
Julesssss 065f4a6
Merge branch 'main' into marcaaron-isMoneyRequestThreadReport
Julesssss 6c1fd55
Update src/components/MoneyRequestHeader.js
luacmartins 4b8645e
Update src/components/MoneyRequestHeader.js
luacmartins 0dce9ec
add translations
luacmartins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to follow up and translate these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we already have translation keys for these: Amount, Cash, Date, Description