-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix zooming image can drag totally outside of the screen #17620
fix zooming image can drag totally outside of the screen #17620
Conversation
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ahmedGaber93 Why "Can't be executed on" other platforms? Zoom feature exists on web so please add videos for all platforms, though drag is not applicable. |
@0xmiroslav I added videos to all platforms, but zoom feature not work on mobile web chrome and safari, the issue found before this fix, it found now on mobile web https://staging.new.expensify.com. |
@ahmedGaber93 please fix typo in Tests step. |
@techievivek @ahmedGaber93 I found weird behavior while testing (also reported on slack). I think this can be out of scope for this GH since this happens on main. bug2.mp4 |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemchrome.mp4Mobile Web - Safarimsafari.mp4DesktopiOSios.mp4Androidandroid.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.4-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.4-0 🚀
|
Details
Fixed Issues
$ #16558
$ #16558 (comment)
Tests
android and ios
Offline tests
N/A
QA Steps
Same as Tests step
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-04-18.at.11.26.49.PM.mov
Mobile Web - Chrome
Screen.Recording.2023-04-18.at.11.31.13.PM.mov
Mobile Web - Safari
Screen.Recording.2023-04-18.at.11.28.48.PM.mov
Desktop
Screen.Recording.2023-04-18.at.11.26.08.PM.mov
iOS
Screen.Recording.2023-04-18.at.6.01.44.PM.mov
Android
Screen.Recording.2023-04-18.at.6.04.12.PM.mov