-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send homeAddressStreet parameter to prevent autoformatting #17220
Conversation
@thesahindia @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@thesahindia you won't be able to test this yet since it relies on a backend change - I can let you know when that's ready for checking, or we can just rely on @roryabraham which should be fine too. |
Off hold and ready for review! Should work on prod now |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-04-17.at.4.56.17.PM.movDesktopScreen.Recording.2023-04-17.at.5.04.57.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
cc: @roryabraham
@dangrous, looks like we have the same issue in city field Screen.Recording.2023-04-17.at.5.27.45.PM.mov |
Thanks @thesahindia, let's address that in a follow-up though? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Yeah @thesahindia do you want to put that in Slack and we can make a separate issue? Include a link to this issue so we can make sure we give context to make the fix as easy as possible. thanks! |
Yeah, I will do that. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.1-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.1-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀
|
Details
Fixed Issues
$ #16960
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android