-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go back link to initial route on Not Found Page #15776
Add go back link to initial route on Not Found Page #15776
Conversation
@mountiny @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Also needs someone to review copy:
|
@@ -37,6 +48,15 @@ const BlockingView = props => ( | |||
/> | |||
<Text style={[styles.notFoundTextHeader]}>{props.title}</Text> | |||
<Text style={[styles.textAlignCenter]}>{props.subtitle}</Text> | |||
{!!props.shouldShowBackHomeLink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why !! even after we gave a default prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup default prop is good, but the main concern when using some text with condition it safe to use !! - to avoid any potential crash, if some prop will be mixed/not used correctly from parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we use this in our codebase anywhere, could we explore some other way to achieve this jsut so we dont introduce this pattern here? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed changes thanks!
Reviewer Checklist
Screenshots/VideosAll DevicesAll.Devices.mov |
@@ -641,6 +641,7 @@ export default { | |||
notHere: 'Hmm… no está aquí', | |||
pageNotFound: 'La página que buscas no existe.', | |||
noAccess: 'No tienes acceso a este chat', | |||
goBackHome: 'Volver a la página principal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asked internally to confirm this
@@ -37,6 +48,15 @@ const BlockingView = props => ( | |||
/> | |||
<Text style={[styles.notFoundTextHeader]}>{props.title}</Text> | |||
<Text style={[styles.textAlignCenter]}>{props.subtitle}</Text> | |||
{!!props.shouldShowBackHomeLink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we use this in our codebase anywhere, could we explore some other way to achieve this jsut so we dont introduce this pattern here? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narefyev91 just a translation change.
@@ -641,6 +641,7 @@ export default { | |||
notHere: 'Hmm… no está aquí', | |||
pageNotFound: 'La página que buscas no existe.', | |||
noAccess: 'No tienes acceso a este chat', | |||
goBackHome: 'Volver a la página principal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goBackHome: 'Volver a la página principal', | |
goBackHome: 'Regresar a la página principal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok scrap this, they changed their minds
🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.82-2 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.82-4 🚀
|
With #16453 PR, we have slightly change the behavior of "Go back to homepage" link to go back to LHN instead of the last opened report in small screen devices. |
Details
We should have go back link if user get on Not Found Page, to make interaction faster and clear how to move to main page
Fixed Issues
$ #15719
$ #15719 (comment)
Tests
Offline tests
This feature doesn't change or is impacted by offline mode.
QA Steps
Same as above.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
android-web.mov
Mobile Web - Safari
ios-web.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov