-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't select emoji on enter when no emoji is highlighted in emoji picker #15236
Conversation
@rushatgabhane @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebWeb.movDesktopScreen.Recording.2023-02-20.at.11.45.04.mov |
Hey @hayata-suenaga, instead of testing Mobile Web alongside Safari Web I'll test the Desktop version instead, pretty sure we can use the keyboard keys there too : ) |
straightforward fix. don't think this requires c+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.2.75-0 🚀
|
🚀 Deployed to production by https://github.com/melvin-bot[bot] in version: 1.2.75-0 🚀
|
Details
Fixed Issues
$ #15232
When no emoji is highlighted (when there is no emoji that hit the search keyword), don't try to select a highlighted emoji upon press enter (because there is no highlighted emoji).
Tests
Open New Expensify on Chrome or Safari on laptops
Go to any chat room
Click Emoji button in the text box to open Emoji Picker Menu
Make sure that you have the search box above the list of emojis (if you don't see the search box, increase the size of the browser window. The search field only appears when the window size is big enough).
Type a gibberish word and make sure you don't see any emoji ("No results found" message should appear)
Hit enter
Verify that no errors appear in the JS console
Delete the gibberish word you entered. Type "smile"
Make sure a smile emoji that is suggested is highlighted
Hit enter
The smile emoji should appear in the message text box
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Mobile Web - Chrome
Chrome
https://user-images.githubusercontent.com/98560306/219807278-abc3d340-f67c-4601-a926-9ea783c4800d.mov
Safari
Screen.Recording.2023-02-17.at.2.29.00.PM.mov
This PR is only relevant to Chrome and Safari on laptops as text field for searching through emojis is shown only when browser size is wide enough.