Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add/remove reaction #15210

Merged
merged 74 commits into from
Mar 8, 2023
Merged

feat: add/remove reaction #15210

merged 74 commits into from
Mar 8, 2023

Commits on Feb 15, 2023

  1. wip: render quick reactions in context menu

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    80333cb View commit details
    Browse the repository at this point in the history

  2. wip: adjustments for web

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    071b88f View commit details
    Browse the repository at this point in the history

  3. add actions for adding and removing reactions

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a984a0b View commit details
    Browse the repository at this point in the history

  4. wip: add reaction when using quick reactions

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f96b73b View commit details
    Browse the repository at this point in the history

  5. render emoji reactions underneath a message

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a164fa1 View commit details
    Browse the repository at this point in the history

  6. TEMP: REMOVE ME once accountID on personal details is live

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f0926c1 View commit details
    Browse the repository at this point in the history

  7. change from login to accountID

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    318931f View commit details
    Browse the repository at this point in the history

  8. wip: adding / removing

    @hannojg
    hannojg committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    549bcbe View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. change: when removing reactions, remove the whole emoji object

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c7de8cd View commit details
    Browse the repository at this point in the history

  2. cleanup code

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    7281f82 View commit details
    Browse the repository at this point in the history

  3. show AddReactionBubble in the row of reactions as well

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    7907fd2 View commit details
    Browse the repository at this point in the history

  4. implemented toggling reactions when selecting the same again

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    71220c0 View commit details
    Browse the repository at this point in the history

  5. close context menu when open emoji picker or selected emoji

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    44909ab View commit details
    Browse the repository at this point in the history

  6. fix emoji picker being wrong positioned

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8042b9b View commit details
    Browse the repository at this point in the history

  7. wip: mini menu

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    483b119 View commit details
    Browse the repository at this point in the history

  8. wip: mini menu adding add reaction icon

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    20d463c View commit details
    Browse the repository at this point in the history

  9. fix: mini menu open picker wrong positioned + was closing

    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    99bfb91 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' of github.com:margelo/expensify-app-fork into han… 

    …no/feat-add-remove-reactions
    @hannojg
    hannojg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    2f61782 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. fix: open emoji picker on mobile

    @hannojg
    hannojg committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    85357b1 View commit details
    Browse the repository at this point in the history

  2. clean up

    @hannojg
    hannojg committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    4c07ba2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. rename and document functions

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    e064297 View commit details
    Browse the repository at this point in the history

  2. pick the preferred skin tone

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    52a9135 View commit details
    Browse the repository at this point in the history

  3. updated JSDocs

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    c8c450c View commit details
    Browse the repository at this point in the history

  4. updated JSDocs

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    bf7d78e View commit details
    Browse the repository at this point in the history

  5. updated JSDocs

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    f874ea5 View commit details
    Browse the repository at this point in the history

  6. remove todos

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    267338e View commit details
    Browse the repository at this point in the history

  7. apply suggestions from design doc

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b09e44d View commit details
    Browse the repository at this point in the history

  8. apply suggestions from design doc

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    1b8041f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' of github.com:margelo/expensify-app-fork into han… 

    …no/feat-add-remove-reactions
    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    33c0554 View commit details
    Browse the repository at this point in the history

  10. fix tests

    @hannojg
    hannojg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    8675022 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. fix: pas emoji object directly

    @hannojg
    hannojg committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    57082d6 View commit details
    Browse the repository at this point in the history

  2. refactor: pass ref optional as arg

    @hannojg
    hannojg committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    28f80d3 View commit details
    Browse the repository at this point in the history

  3. fix: pass anchor position for emoji picker as well to fix issue with … 

    …positioning
    @hannojg
    hannojg committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ba6970e View commit details
    Browse the repository at this point in the history

  4. apply suggestions from code review

    @hannojg
    hannojg committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f2e407c View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into han… 

    …no/feat-add-remove-reactions
    @hannojg
    hannojg committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    97c8d08 View commit details
    Browse the repository at this point in the history

  2. enable API calls

    @hannojg
    hannojg committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    3b24a03 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into han… 

    …no/feat-add-remove-reactions
    @hannojg
    hannojg committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    f4c94d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. fix issue where reactions won't re-render

    @hannojg
    hannojg committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    8bc100b View commit details
    Browse the repository at this point in the history

  2. temp fix toggling reactions is broken

    @hannojg
    hannojg committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    e9ba4f5 View commit details
    Browse the repository at this point in the history

  3. fix removing reactions causing artefacts

    @hannojg
    hannojg committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    55834f6 View commit details
    Browse the repository at this point in the history

  4. fix regression where mini menu items weren't displaying correctly

    @hannojg
    hannojg committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    1cb6d60 View commit details
    Browse the repository at this point in the history

  5. fix: don't remove reactions when editing a message 

    Note: This only works locally. Pusher currently will send an event after the edit that doesn't carry any reactions and as such will overwrite the data
    @hannojg
    hannojg committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    516ef3a View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. expose hasAccountIDReacted

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    adb6e7d View commit details
    Browse the repository at this point in the history

  2. apply code suggestion

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    debe8ad View commit details
    Browse the repository at this point in the history

  3. Update src/libs/actions/Report.js 

    Co-authored-by: Brandon Stites <42391420+stitesExpensify@users.noreply.github.com>
    @hannojg @stitesExpensify
    hannojg and stitesExpensify authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    8ed9e99 View commit details
    Browse the repository at this point in the history

  4. apply code suggestion

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    d8fa085 View commit details
    Browse the repository at this point in the history

  5. apply code suggestion

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    da0e536 View commit details
    Browse the repository at this point in the history

  6. apply code suggestion

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5b2c512 View commit details
    Browse the repository at this point in the history

  7. apply code suggestion

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5842cf7 View commit details
    Browse the repository at this point in the history

  8. remove unnecessary requestLayoutAnimation

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    952fe98 View commit details
    Browse the repository at this point in the history

  9. added translations

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    dd48b96 View commit details
    Browse the repository at this point in the history

  10. match text

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c7c3411 View commit details
    Browse the repository at this point in the history

  11. reflect preferred skin tone in the rest of the UI

    @hannojg
    hannojg committed Mar 6, 2023
    1 Configuration menu
    Copy the full SHA
    db1026a View commit details
    Browse the repository at this point in the history

  12. fixed bug where mini context menu wouldn't close

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5e7e7c1 View commit details
    Browse the repository at this point in the history

  13. fix: make emojis in quick reaction unselectable

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b73de4b View commit details
    Browse the repository at this point in the history

  14. fix: immediately remove reaction bar when no reactions are present an… 

    …ymore
    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5db0b1f View commit details
    Browse the repository at this point in the history

  15. fix tests

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    231fb63 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' of github.com:margelo/expensify-app-fork into han… 

    …no/feat-add-remove-reactions
    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    96d55ae View commit details
    Browse the repository at this point in the history

  17. fix warning

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    662c8ef View commit details
    Browse the repository at this point in the history

  18. suppress eslint warning

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f45dfeb View commit details
    Browse the repository at this point in the history

  19. remove unused default props

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    91dc75f View commit details
    Browse the repository at this point in the history

  20. remove focusable prop as not needed on web

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5a62b43 View commit details
    Browse the repository at this point in the history

  21. add tooltip

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1e5c971 View commit details
    Browse the repository at this point in the history

  22. fix key issue

    @hannojg
    hannojg committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    cd93903 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. fix focusable prop

    @hannojg
    hannojg committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    6520062 View commit details
    Browse the repository at this point in the history

  2. rename to openContextMenu and shouldKeepOpen

    @hannojg
    hannojg committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d63a77b View commit details
    Browse the repository at this point in the history

  3. Revert "TEMP: REMOVE ME once accountID on personal details is live" 

    This reverts commit f0926c1.
    @hannojg
    hannojg committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e332259 View commit details
    Browse the repository at this point in the history

  4. add container styles back

    @hannojg
    hannojg committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    effd5f4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:margelo/expensify-app-fork into han… 

    …no/feat-add-remove-reactions
    @hannojg
    hannojg committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    840e381 View commit details
    Browse the repository at this point in the history

  6. skip reactions for IOU messages for now 

    due to backend issues
    @hannojg
    hannojg committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    dd5b07c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. fix focus on AddReactionBubble

    @hannojg
    hannojg committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7af1573 View commit details
    Browse the repository at this point in the history

  2. fix safari selection bug

    @hannojg
    hannojg committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    baa93cc View commit details
    Browse the repository at this point in the history

  3. fix adding multiple times the same reaction

    @hannojg
    hannojg committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9b8e1ac View commit details
    Browse the repository at this point in the history

  4. check specifically for undefined

    @hannojg
    hannojg committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9e3596f View commit details
    Browse the repository at this point in the history