Refactor: Create libs/ApiUtils #15178

kidroca · 2023-02-15T17:55:33Z

Details

Introduce ApiUtils and ApiUtils.getApiRoot

Why?

https://expensify.slack.com/archives/C01GTK53T8Q/p1676320010253979
We build native apps using the PROD env config
The API is resolved dynamically at run time
But we also have the constant URL_API_ROOT which cannot always point to the correct API (it points to PROD)
Some ENVs (staging) allow for toggling between different APIs and a function like getApiRoot encapsulates
the checks we have to make when we want to use the root url

The staging toggle now works correctly on DEV and it can switch between the PRIMARY and STAGING APIs

Fixed Issues

$ #15087
PROPOSAL: N/A

Tests

Verify staging and prod urls are resolved from API ROOT
- Follow the steps from the issue description [HOLD for payment 2023-02-08] [$1000] Backend - Attachment links capture the environment they are from #14227 (comment) in order to create attachment links from staging and prod.
- Inspect the Network tab or the HTML source (Chrome Dev tools -> Elements tab) to verify any attachment url (staging or prod) is resolved against the API ROOT of the current environment
Verify absolute urls are resolved from API ROOT
- At the moment the backend is not yet saving attachments using the absolute path, so we need to simulate the result
- We need to inspect and modify Onyx data
- Find an attachment action and modify the html of the message so that the <img src="https://{env}.expensify.com/chat-attachments/{path}" /> part becomes <img src="/chat-attachments/{path}" />
  Example
  In Chrome dev console:
```
Onyx.connect({ key: 'reportActions_71955477', callback: actions => {
    const action = actions[932];
    action.message[0].html = action.message[0].html.replace('https://staging.expensify.com/', '/');
    Onyx.merge('reportActions_71955477', { 932: action });
}});
```
- Now refresh the browser. The (modified) attachment should resolve and load successfully from API ROOT
Verify all attachment usages are covered. All these places should resolve the attachment from API ROOT
- attachment thumbnail in chat message comments
- attachment preview modal
- attachment download button
- use different attachment types - image formats / document formats
Settings / Preferences / Test Preferences - staging toggle works correctly on DEV and STAGING
- It should switch between PRIMARY (PROD) and STAGING urls
- Keep in mind that on WEB using the STAGING API would case CORS errors, it needs further changes to the proxy server covered in the follow-up for [Staging API] To Use Staging Server or not to use staging server #15517
Using the "Staging toggle" changes the attachment URLs
- switching to the staging api and viewing attachment requests on the network tab should show staging.expensify.com/chat-attachments/... (or whatever STAGING_EXPENSIFY_URL address is configured in .env)
- You can use Desktop to inspect this
Pusher functionality should be unaffected
- there was a rename that touched Pusher code, but nothing was altered. Pusher should still subscribe and be able to receive new messages live
AddressSearch component functionality was refactored, verify GooglePlacesAutocomplete has no regression regarding the requestUrl parameter. The fields below should show autocomplete suggestions
- http://localhost:8080/settings/payments/add-debit-card (Billing Address)
- http://localhost:8080/settings/profile/personal-details/address (Address Line 1)

Offline tests

Expected Offline behavior

Images that were seen recently should be visible and render instantly (from cache)
Images that haven't been already loaded would be blank

Expected slow internet behavior

Images that were seen recently should be visible and render instantly (from cache)
Other images would display a spinner / loader animation for a while until they load

QA Steps

Testing on STAGING

Go to PRODUCTION and upload attachments
Go to STAGING and view the uploaded attachments

Attachments should load successfully
Requests on the network tab should be directed to staging.expensify.com/chat-attachments/...
Upload different attachment types and verify they work
Upload attachments from STAGING - uploaded and viewing them should still work
Verify all attachment usages are covered. All these places should load and render successfully
- attachment thumbnail in chat message comments
- attachment preview modal
- attachment download button
- use different attachment types - image formats / document formats
Settings / Preferences / Test Preferences - Staging toggle is rendered and we can switch between PROD and STAGING API
Using the "Staging toggle" changes the attachment URLs
- switching to the prod api and viewing attachment requests on the network tab should show www.expensify.com/chat-attachments/...
AddressSearch component functionality was refactored, verify address can still be autocomplete
- e.g. Address Line 1 here: https://staging.new.expensify.com/settings/profile/personal-details/address
- another place to check is "Add Debit Card" (settings / Payments), for the Billing address here: https://staging.new.expensify.com/settings/payments

Testing on PRODUCTION

After PR is merged to PROD

Go to STAGING and upload attachments
Go to PRODUCTION and view the uploaded attachments

Attachments should load successfully
Requests on the network tab should be directed to www.expensify.com/chat-attachments/...
Upload different attachment types and verify they work
Upload attachments from PRODUCTION - uploaded and viewing them should still work
Verify all attachment usages are covered. All these places should load and render successfully
- attachment thumbnail in chat message comments
- attachment preview modal
- attachment download button
- use different attachment types - image formats / document formats
Settings / Preferences / Test Preferences - staging toggle is not rendered on PROD
AddressSearch component functionality was refactored, verify address can still be autocomplete
- e.g. Address Line 1 here: https://new.expensify.com/settings/profile/personal-details/address
- another place to check is "Add Debit Card" (settings / Payments), for the Billing address here: https://new.expensify.com/settings/payments

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-02-15T17:55:37Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

kidroca

I've pointed out some usages of URL_API_ROOT that might be confusing or be set by mistake to the production API root, because URL_API_ROOT always points there

src/CONFIG.js

src/components/AddressSearch.js

src/components/TestToolMenu.js

src/libs/HttpUtils.js

src/libs/Navigation/AppNavigator/AuthScreens.js

src/libs/tryResolveUrlFromApiRoot.js

tests/actions/ReportTest.js

tests/ui/UnreadIndicatorsTest.js

mountiny · 2023-02-15T18:52:53Z

cc @tgolen @marcaaron if you would want to review this too 🙌

MelvinBot · 2023-02-17T08:41:44Z

@Santhosh-Sellavel @ctkochan22 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kidroca · 2023-02-17T08:43:20Z

Added description, tests and QA tests and screenshots

✅ Ready for Review

We still need to decide what to do about the remaining direct usages of PRODUCTION_API_ROOT

mountiny · 2023-02-17T10:44:03Z

Just found there is this PR as well which is a bit stepping on our toes here https://github.com/Expensify/App/pull/14944/files

ctkochan22 · 2023-02-17T23:24:19Z

@mountiny Are we still reviewing this PR? Or wait until yours is merged?

Santhosh-Sellavel · 2023-02-21T16:59:30Z

@kidroca Can you please update the test steps here, instead of links?

kidroca · 2023-02-21T17:24:08Z

@Santhosh-Sellavel

@kidroca Can you please update the test steps here, instead of links?

Done, but I think we should wait for the resolution of the PR here (which might call for additional changes on my PR):

Use app environment to determine olddot URL and update staging env #14944

Santhosh-Sellavel · 2023-02-21T17:25:57Z

Cool, then can you update the title HOLD For the PR?

mountiny · 2023-02-22T18:37:10Z

Put this on hold, @ctkochan22 sorry was ooo on monday and tuesday

ctkochan22 · 2023-02-27T20:07:15Z

@mountiny Looks like you got a handle on this review. I'm going to unassign and defer to you!

kidroca

This PR is ready for review and testing ✅

Made some changes to be compatible with other PRs touching the same functionality
It was possible to remove the platform specific implementations for ApiUtils sub functionality

We are no longer blocked by:

Use app environment to determine olddot URL and update staging env #14944 - no overlapping changes
[Staging API] To Use Staging Server or not to use staging server #15517 - agreed to move with my PR first on slack

Updated PR description and test sections to indicated the "Staging toggle" can be used in DEV
It would cause CORS issues (only on DEV), because the proxy server changes are not there yet. They will be handled in the follow of #15517

src/CONFIG.js

src/libs/Navigation/AppNavigator/AuthScreens.js

src/libs/tryResolveUrlFromApiRoot.js

marcaaron

Looks pretty good. Just left some small ideas for improvements.

src/CONFIG.js

src/components/AddressSearch.js

src/components/TestToolMenu.js

src/libs/ApiUtils.js

src/libs/Navigation/AppNavigator/AuthScreens.js

src/libs/HttpUtils.js

kidroca

Added a few detailed explanations, sorry if it's a bit too long

I can address most of the suggestions right now
But for a few I'll need a response from @marcaaron

src/libs/ApiUtils.js

src/CONFIG.js

src/components/AddressSearch.js

src/components/TestToolMenu.js

kidroca · 2023-03-07T09:26:14Z

src/libs/ApiUtils.js

+    }
+
+    if (typeof stagingServerToggleState !== 'boolean') {
+        return ENV_NAME === CONST.ENVIRONMENT.STAGING;


Yes, though see this
https://github.com/Expensify/App/blob/bb0b7883210a9aba510adf682363004d536e29b4/src/libs/ApiUtils.js#L10-L16

we want the default value for staging to be true, but we can't simply do this

let stagingServerToggleState = ENV_NAME === CONST.ENVIRONMENT.STAGING;

because the real ENV_NAME is resolved a few moments later

We can only do this:

let stagingServerToggleState = false; Onyx.connect({ key: ONYXKEYS.USER, callback: (val) => { const defaultValue = ENV_NAME === CONST.ENVIRONMENT.STAGING; stagingServerToggleState = lodashGet(val, 'shouldUseStagingServer', defaultValue); }, });

It's probably fine, but ENV_NAME is obtained async and it might not be updated in the Onyx.connect callback
IMO the safest is what we have right now
What do you think?

src/libs/Navigation/AppNavigator/AuthScreens.js

src/libs/ApiUtils.js

s77rt · 2023-03-10T22:43:27Z

@kidroca Is this test "Verify absolute urls are resolved from API ROOT" really required? The attachments urls will always be in a different (and correct) format due to the use of tryResolveUrlFromApiRoot.

s77rt · 2023-03-11T11:04:33Z

~~[Web Only] Offline tests fail; going Offline/Slow Connection will always load attachmnets from url and never from cache, this is also the current behaviour on staging. So this can be ignored?~~ I had cache disabled.
[Web Only] Using staging switch will cause CORS ([Staging API] To Use Staging Server or not to use staging server #15517 this PR has been revered). I guess this also have nothing to do with this PR?

Besides that, tests well!, checklist in the way...

s77rt · 2023-03-11T11:27:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mp4

iOS

Android

kidroca · 2023-03-12T11:06:18Z

@kidroca Is this test "Verify absolute urls are resolved from API ROOT" really required? The attachments urls will always be in a different (and correct) format due to the use of tryResolveUrlFromApiRoot.

I'm not sure / I don't know - tryResolveUrlFromApiRoot was from my previous PR and this behavior was tested, but then we realized it didn't respect the "staging toggle"

This PR if a followup to maketryResolveUrlFromApiRoot respect the "staging toggle" and I added the same steps

[Web Only] Offline tests fail; going Offline/Slow Connection will always load attachmnets from url and never from cache, this is also the current behaviour on staging. So this can be ignoreed?

I'm not sure how did you test that
I do this

load a chat with attachments
see thumbnails load (thumbnails get cached)
open one of them (it gets cached)
go to a different chat
go offline
go to chat with attachments again
see thumbnails load
open one of them - it loads
open another one - it doesn't load (full image fails to load as it's not cached)

Screen.Recording.2023-03-12.at.11.53.20.mov

2. [Web Only] Using staging switch will cause CORS ([Staging API] To Use Staging Server or not to use staging server #15517 this PR has been revered). I guess this also have nothing to do with this PR?

That's correct, the followup to fix this is waiting on the current PR

s77rt · 2023-03-12T11:54:05Z

I'm not sure how did you test that

I think it's related to how the browser handle requests while offline, check the video for Web from the checklist above, I went offline differently than how you did. I think that's outside the scope of this PR since same behaviour is on staging and it may be actually a browser thing so nothing to worry about here. Just to be sure can you do the steps I have and confirm the same results

kidroca · 2023-03-13T18:37:51Z

I think it's related to how the browser handle requests while offline, check the video for Web from the checklist above, I went offline differently than how you did.

You have dev tools open and cache disabled - that's why cache won't be used
You can untoggle the checkmark here, and see a request won't be made again

s77rt · 2023-03-13T20:08:09Z

@kidroca Yeah, sorry my bad, I tend to disable cache for testing. So everything is actually as expected, as can be seen on the Desktop video.

Edit: I have updated the Web video

Move the logic inside the Onyx callback

src/libs/ApiUtils.js

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

s77rt

LGTM! 🚀

mountiny

@kidroca one comment, thank I will merge this, thanks!

src/components/TestToolMenu.js

mountiny

Lets do this

s77rt · 2023-03-16T13:50:49Z

@mountiny Do we track payment for this in the linked issue or in another separated issue?

OSBotify · 2023-03-16T13:51:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-17T10:00:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-21T20:09:23Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.87-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-03-21T21:13:47Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.87-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny assigned kidroca Feb 15, 2023

mountiny self-requested a review February 15, 2023 17:59

kidroca commented Feb 15, 2023

View reviewed changes

kidroca marked this pull request as ready for review February 17, 2023 08:41

kidroca requested a review from a team as a code owner February 17, 2023 08:41

melvin-bot bot requested review from ctkochan22 and Santhosh-Sellavel and removed request for a team February 17, 2023 08:41

kidroca mentioned this pull request Feb 17, 2023

[HOLD for payment 2023-03-28] Make sure attachments are fetched from appropriate servers #15087

Closed

mountiny mentioned this pull request Feb 17, 2023

Use app environment to determine olddot URL and update staging env #14944

Merged

54 tasks

mountiny changed the title ~~Refactor: Create libs/ApiUtils~~ [HOLD App#14944] Refactor: Create libs/ApiUtils Feb 22, 2023

ctkochan22 removed their request for review February 27, 2023 20:07

mountiny mentioned this pull request Mar 1, 2023

[Staging API] To Use Staging Server or not to use staging server #15517

Merged

54 tasks

kidroca force-pushed the kidroca/refactor/api-root branch from d34a426 to bb0b788 Compare March 6, 2023 19:23

kidroca commented Mar 6, 2023

View reviewed changes

src/CONFIG.js Outdated Show resolved Hide resolved

src/libs/Navigation/AppNavigator/AuthScreens.js Outdated Show resolved Hide resolved

src/libs/tryResolveUrlFromApiRoot.js Outdated Show resolved Hide resolved

marcaaron reviewed Mar 6, 2023

View reviewed changes

kidroca changed the title ~~[HOLD App#14944] Refactor: Create libs/ApiUtils~~ Refactor: Create libs/ApiUtils Mar 7, 2023

kidroca commented Mar 7, 2023

View reviewed changes

kidroca force-pushed the kidroca/refactor/api-root branch from 5e1b11b to 802f97b Compare March 7, 2023 12:54

s77rt suggested changes Mar 10, 2023

View reviewed changes

src/libs/ApiUtils.js Outdated Show resolved Hide resolved

s77rt suggested changes Mar 10, 2023

View reviewed changes

src/libs/ApiUtils.js Show resolved Hide resolved

This comment was marked as off-topic.

Sign in to view

ApiUtils - remove canUseStagingServer

3be8792

Move the logic inside the Onyx callback

kidroca commented Mar 13, 2023

View reviewed changes

src/libs/ApiUtils.js Outdated Show resolved Hide resolved

s77rt suggested changes Mar 13, 2023

View reviewed changes

src/libs/ApiUtils.js Outdated Show resolved Hide resolved

Docs: Update src/libs/ApiUtils.js

c197b41

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

s77rt previously approved these changes Mar 13, 2023

View reviewed changes

mountiny reviewed Mar 15, 2023

View reviewed changes

src/components/TestToolMenu.js Show resolved Hide resolved

Docs: TestToolMenu code comments

d641fa8

kidroca dismissed s77rt’s stale review via d641fa8 March 16, 2023 13:23

mountiny approved these changes Mar 16, 2023

View reviewed changes

mountiny merged commit 44f9871 into Expensify:main Mar 16, 2023

kidroca deleted the kidroca/refactor/api-root branch March 16, 2023 13:51

OSBotify mentioned this pull request Mar 17, 2023

Deploy Checklist: New Expensify 2023-03-17 #16074

Closed

9 tasks

This was referenced Mar 17, 2023

IOS - Chat -Image added on production (mweb/chrome) does not show on IOS staging, only after re-log #16088

Closed

[HOLD for payment 2023-04-04] Attachments (w/o preview: mp4, docx etc) use Prod domain in case of download #16327

Closed

Prince-Mendiratta mentioned this pull request Mar 22, 2023

[HOLD for payment 2023-04-05] [$4000] Dev: Connect to bank account is not opening Sandbox page on dev server, redirects to real bank website #12315

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: Create libs/ApiUtils #15178

Refactor: Create libs/ApiUtils #15178

kidroca commented Feb 15, 2023 •

edited

Loading

MelvinBot commented Feb 15, 2023

kidroca left a comment

mountiny commented Feb 15, 2023

MelvinBot commented Feb 17, 2023

kidroca commented Feb 17, 2023

mountiny commented Feb 17, 2023

ctkochan22 commented Feb 17, 2023

Santhosh-Sellavel commented Feb 21, 2023

kidroca commented Feb 21, 2023

Santhosh-Sellavel commented Feb 21, 2023

mountiny commented Feb 22, 2023

ctkochan22 commented Feb 27, 2023

kidroca left a comment •

edited

Loading

marcaaron left a comment

kidroca left a comment •

edited

Loading

kidroca Mar 7, 2023

s77rt commented Mar 10, 2023

s77rt commented Mar 11, 2023 •

edited

Loading

s77rt commented Mar 11, 2023 •

edited

Loading

This comment was marked as off-topic.

kidroca commented Mar 12, 2023

s77rt commented Mar 12, 2023

kidroca commented Mar 13, 2023

s77rt commented Mar 13, 2023 •

edited

Loading

s77rt left a comment

mountiny left a comment

mountiny left a comment

s77rt commented Mar 16, 2023

OSBotify commented Mar 16, 2023

OSBotify commented Mar 17, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 21, 2023

Refactor: Create libs/ApiUtils #15178

Refactor: Create libs/ApiUtils #15178

Conversation

kidroca commented Feb 15, 2023 • edited Loading

Details

Why?

Fixed Issues

Tests

Offline tests

QA Steps

Testing on STAGING

Testing on PRODUCTION

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 15, 2023

kidroca left a comment

Choose a reason for hiding this comment

mountiny commented Feb 15, 2023

MelvinBot commented Feb 17, 2023

kidroca commented Feb 17, 2023

mountiny commented Feb 17, 2023

ctkochan22 commented Feb 17, 2023

Santhosh-Sellavel commented Feb 21, 2023

kidroca commented Feb 21, 2023

Santhosh-Sellavel commented Feb 21, 2023

mountiny commented Feb 22, 2023

ctkochan22 commented Feb 27, 2023

kidroca left a comment • edited Loading

Choose a reason for hiding this comment

marcaaron left a comment

Choose a reason for hiding this comment

kidroca left a comment • edited Loading

Choose a reason for hiding this comment

kidroca Mar 7, 2023

Choose a reason for hiding this comment

s77rt commented Mar 10, 2023

s77rt commented Mar 11, 2023 • edited Loading

s77rt commented Mar 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

This comment was marked as off-topic.

kidroca commented Mar 12, 2023

s77rt commented Mar 12, 2023

kidroca commented Mar 13, 2023

s77rt commented Mar 13, 2023 • edited Loading

s77rt left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

s77rt commented Mar 16, 2023

OSBotify commented Mar 16, 2023

OSBotify commented Mar 17, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 21, 2023

kidroca commented Feb 15, 2023 •

edited

Loading

kidroca left a comment •

edited

Loading

kidroca left a comment •

edited

Loading

s77rt commented Mar 11, 2023 •

edited

Loading

s77rt commented Mar 11, 2023 •

edited

Loading

s77rt commented Mar 13, 2023 •

edited

Loading