Fix malformed app icon on old Android devices #15177

Julesssss · 2023-02-15T17:51:30Z

Details

Updates the Android app to use adaptive icons, to make sure all new/old versions of Android display the icon correctly. I used the Android Studio image asset tool to ensure each DPI bucket was created correctly.

Fixed Issues

$ #14252

Tests

Install the app to an Android Emulator or physical device
- Please try both new (Android 13) and old (Android 8) devices/emulators
The app icon should display correctly, and shouldn't show as a large square icon (see the before screenshot)

Offline tests

N/A

QA Steps

Install the app to an Android Emulator or physical device
- Please try both new (Android 13) and old (Android 8) devices/emulators
The app icon should display correctly, and shouldn't show as a large square icon (see the before screenshot)

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Only Android was modified

Android 8 Before	Android 8 After	Android 13 Before/After

MelvinBot · 2023-02-15T17:52:40Z

@rushatgabhane @sketchydroide One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-02-17T11:16:06Z

Bumping this

MelvinBot · 2023-02-17T11:16:44Z

@rushatgabhane @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-02-20T06:20:31Z

@Julesssss im getting the following error when trying to run dev on Pixel XL API level 26.

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':app:packageRelease' (type 'PackageApplication').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.tasks.PackageApplication' property 'signingConfigData.signingConfigData.storeFile' specifies file '/Users/rushatgabhane/code/EXPENSIFY_APP/android/app/my-upload-key.keystore' which doesn't exist.
    
    Reason: An input file was expected to be present but it doesn't exist.
    
    Possible solutions:
      1. Make sure the file exists before the task is called.
      2. Make sure that the task which produces the file is declared as an input.
    
    Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#input_file_does_not_exist for more details about this problem.

BUILD FAILED in 10m 51s
1813 actionable tasks: 1497 executed, 316 up-to-date
error Failed to build the app.
Error: Command failed: ./gradlew build -x lint
    at makeError (/Users/rushatgabhane/code/EXPENSIFY_APP/node_modules/@react-native-community/cli-platform-android/node_modules/execa/index.js:174:9)
    at Function.module.exports.sync (/Users/rushatgabhane/code/EXPENSIFY_APP/node_modules/@react-native-community/cli-platform-android/node_modules/execa/index.js:338:15)
    at buildApk (/Users/rushatgabhane/code/EXPENSIFY_APP/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:141:22)
    at runOnSpecificDevice (/Users/rushatgabhane/code/EXPENSIFY_APP/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:122:7)

rushatgabhane · 2023-02-20T06:29:27Z

i tried gradlew clean and clearing npm cache

Julesssss · 2023-02-20T10:16:15Z

my-upload-key.keystore

You have to create a new Keystore or locate this old one, the one you specified doesn't seem to exist.

Try this in Android studio: Build > Generate Signed Bundle or APK > APK > Create New

rushatgabhane · 2023-02-20T11:58:21Z

Thanks, fixed that.
New problem: Stackoverflow 😅

my mac has 8gb+ free memory. tried npm ci

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':oguzhnatly_react-native-image-manipulator:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR:/Users/rushatgabhane/code/EXPENSIFY_APP/node_modules/@oguzhnatly/react-native-image-manipulator/android/build/intermediates/merged_res/release/values/values.xml:2722: AAPT: error: resource android:attr/lStar not found.
         

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
java.lang.StackOverflowError (no error message)

Julesssss · 2023-02-20T15:33:25Z

Oh damn. I sometimes see this too.

Usually it passes on the second time I attempt to build it. Else, restarting my machine sometimes helps.

Julesssss · 2023-02-20T15:33:47Z

But if this doesn't work for you let me know and I'll send you my release build directly.

rushatgabhane · 2023-02-20T18:25:30Z

@Julesssss no luck :(
tried system reboot and 3 build attempts.

Execution failed for task ':oguzhnatly_react-native-image-manipulator:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR:/Users/rushatgabhane/code/EXPENSIFY_APP/node_modules/@oguzhnatly/react-native-image-manipulator/android/build/intermediates/merged_res/release/values/values.xml:2722: AAPT: error: resource android:attr/lStar not found.

2: Task failed with an exception.
-----------
* What went wrong:
java.lang.StackOverflowError (no error message)

Julesssss · 2023-02-21T10:50:49Z

@rushatgabhane my first build failed after 9(!!) minutes lol. Just sent you a signed apk. You should be able to just drag and drop onto your emulator.

rushatgabhane

Thanks for the help @Julesssss

@cristipaval LGTM! 🎉

rushatgabhane · 2023-02-21T11:08:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Android 8

Android 12

Julesssss · 2023-02-21T14:17:20Z

Over to you @cristipaval

OSBotify · 2023-02-21T19:14:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-21T21:15:04Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-22T22:57:33Z

🚀 Deployed to production by https://github.com/melvin-bot[bot] in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss added 2 commits February 15, 2023 17:42

update Android icons to support all device versions

dacd40f

Merge branch 'main' into jules-fixOldDevicesAndroidIcon

da3d806

Julesssss self-assigned this Feb 15, 2023

Julesssss marked this pull request as ready for review February 15, 2023 17:51

Julesssss requested a review from a team as a code owner February 15, 2023 17:51

Julesssss changed the title ~~Jules fix old devices android icon~~ Fix malformed app icon on old Android devices Feb 15, 2023

melvin-bot bot requested review from rushatgabhane and sketchydroide and removed request for a team February 15, 2023 17:52

Julesssss added 2 commits February 15, 2023 17:55

put icon assets in default directory

1f7f1b4

remove assets from debug flavour

fed7f5c

Julesssss requested review from a team and removed request for sketchydroide February 17, 2023 11:15

melvin-bot bot requested review from cristipaval and removed request for a team February 17, 2023 11:16

Merge branch 'main' into jules-fixOldDevicesAndroidIcon

80d3145

rushatgabhane approved these changes Feb 21, 2023

View reviewed changes

cristipaval approved these changes Feb 21, 2023

View reviewed changes

cristipaval merged commit d6b695f into main Feb 21, 2023

cristipaval deleted the jules-fixOldDevicesAndroidIcon branch February 21, 2023 19:10

OSBotify mentioned this pull request Feb 21, 2023

Deploy Checklist: New Expensify 2023-02-21 #15329

Closed

19 tasks

MelvinBot mentioned this pull request Feb 22, 2023

[$1000] [HOLD for payment 2023-03-01] Expensify app icon looks different #14252

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix malformed app icon on old Android devices #15177

Fix malformed app icon on old Android devices #15177

Julesssss commented Feb 15, 2023 •

edited

Loading

MelvinBot commented Feb 15, 2023

Julesssss commented Feb 17, 2023

MelvinBot commented Feb 17, 2023

rushatgabhane commented Feb 20, 2023 •

edited

Loading

rushatgabhane commented Feb 20, 2023

Julesssss commented Feb 20, 2023

rushatgabhane commented Feb 20, 2023 •

edited

Loading

Julesssss commented Feb 20, 2023

Julesssss commented Feb 20, 2023

rushatgabhane commented Feb 20, 2023

Julesssss commented Feb 21, 2023

rushatgabhane left a comment

rushatgabhane commented Feb 21, 2023

Julesssss commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 22, 2023

Fix malformed app icon on old Android devices #15177

Fix malformed app icon on old Android devices #15177

Conversation

Julesssss commented Feb 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 15, 2023

Julesssss commented Feb 17, 2023

MelvinBot commented Feb 17, 2023

rushatgabhane commented Feb 20, 2023 • edited Loading

rushatgabhane commented Feb 20, 2023

Julesssss commented Feb 20, 2023

rushatgabhane commented Feb 20, 2023 • edited Loading

Julesssss commented Feb 20, 2023

Julesssss commented Feb 20, 2023

rushatgabhane commented Feb 20, 2023

Julesssss commented Feb 21, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

rushatgabhane commented Feb 21, 2023

Reviewer Checklist

Screenshots/Videos

Android 8

Android 12

Julesssss commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 22, 2023

Julesssss commented Feb 15, 2023 •

edited

Loading

rushatgabhane commented Feb 20, 2023 •

edited

Loading

rushatgabhane commented Feb 20, 2023 •

edited

Loading