Skip call for deactivateLabel when autofill text exists

[hayata-suenaga]

Details

When a blur event is fired, deactivateLabel method is invoked inside onBlur event handler.

deactivateLabel method determines if the position of input label should be really updated based on the current input value. If there is already text, it does not deactivate (i.e. move the input label down closer to the input field).

For deactivateLabel to properly determine its course of action, the value state value should be synced to the text inputted in the text field. This is usually fine, as the value state value is updated in the onChangeText callback as the user types, deletes or pastes texts into the field.

However, the onChangeText callback is not invoked when the text value is autofilled by Chrome (ex. for username and password). This results in the value state not synced with the text displayed in the text field.

When the value state value is empty but the text field is not for this reason, deactivateLabel thinks it should move the label down to indicate deactivation state, making the label overlap with the displayed input text.

The straight forward solution to this problem is to make sure the value is synced with the displayed text when the input is autofilled by Chrome. However, there is no solution for this at this moment.

This is not React Native specific problem. When autofilling a text, Chrome doesn't trigger a change event or even register the text value with the input element until user performs some kind of action WITHIN the page (ex. clicking on somewhere on the page). In other words, when you cause a blur event without any direct user interaction WITHIN the website, the value state is not updated. This is why this issue only happens when the user clicks outside the website (ex. url bar or outside Chrome window itself). Triggering an arbitrary event programmatically doesn't work either.

The workaround for this issue is to check for the existence of a sudo selector that Chrome internally use. When this selector is present, deactivateLabel should not be invoked. After the user edits the autofilled text, this selector is removed. However, because this is an internal selector, we don't know when this selector might change.

Fixed Issues

$ #14801

Tests / Offline Tests / QA Steps

Check the issue has been fixed

1. Open Chrome on laptop
2. Follow this and this instructions to make sure Chrome can save and autofill your username
3. Logout from New Expensify if you're logged in
4. Go to sign in page and wait for the username to be autofilled by Chrome
5. Click anywhere outside the website (URL Bar, Share Button, or outside Chrome window)
6. Check the text input label Phone or email is not overlapped with the text that is autofilled by Chrome
7. Verify that no errors appear in the JS console

Check this PR didn't break the normal behavior

8. Delete the username that is autofilled by Chrome
9. Click outside the text field to remove the focus from the field
10. Check the label Phone or email moves a little bit downward to indicate inactive state.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-02-15.at.11.03.26.AM.mov

Screen.Recording.2023-02-15.at.11.09.07.AM.mov

Mobile Web - Chrome

android.chrome.webm

Mobile Web - Safari

iphone.safari.mp4

Desktop

Screen.Recording.2023-02-15.at.2.19.13.PM.mov

iOS

iphone.native.mp4

Android

android.native.webm

[MelvinBot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[parasharrajat]

Awesome explanation. This might be the first PR in 2 months where I have seen a proper explanation. Thank you.

[MelvinBot]

@parasharrajat @stitesExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

@parasharrajat @stitesExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

@stitesExpensify Any thoughts? #15159 (comment)

[parasharrajat]

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

screen-2023-02-21_23.10.59.mp4

🔲 Android / Chrome

screen-2023-02-21_23.20.28.mp4

🔲 Android / native

screen-2023-02-22_17.34.41.mp4

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

[MelvinBot]

@hayata-suenaga looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[hayata-suenaga]

@yuwenmemon MelvinBot checked this as Emergency. Could you explain why it might have done so? Did I forget to check some steps? Did I forget to wait for reviewer checklist?

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	724.758 ms → 758.065 ms (+33.307 ms, +4.6%)
App start runJsBundle	198.594 ms → 209.719 ms (+11.125 ms, +5.6%)
App start nativeLaunch	19.968 ms → 19.967 ms (-0.001 ms, ±0.0%)
App start regularAppStart	0.023 ms → 0.016 ms (-0.007 ms, -30.2%) 🟢
Open Search Page TTI	618.785 ms → 611.815 ms (-6.970 ms, -1.1%)

Show details

Name	Duration
App start TTI	Baseline Mean: 724.758 ms Stdev: 27.610 ms (3.8%) Runs: 664.8249590024352 673.7049899995327 676.2711360007524 678.0941129997373 688.7514759972692 703.2770159989595 703.8135870024562 704.9370559975505 708.6303690001369 712.0665429979563 716.9200130030513 718.8704779967666 719.9112870022655 721.2703040018678 724.5670500025153 726.9097340032458 729.8968549966812 730.7383119985461 731.4859429970384 732.2933819964528 738.3110710009933 739.4004329964519 744.851538002491 747.617554999888 747.7730910032988 750.4864910021424 752.4785119965672 753.8762750029564 754.7771029993892 754.9347380027175 758.6014230027795 781.9096129983664 Current Mean: 758.065 ms Stdev: 28.032 ms (3.7%) Runs: 704.8920919969678 705.0633179992437 714.8363670036197 718.8579630032182 721.3171489983797 726.0867960005999 731.0623940005898 735.898039996624 735.9896010011435 742.5907529965043 742.9696580022573 749.6408120021224 751.4162250012159 755.400098003447 758.5118310004473 759.5139999985695 759.9404510036111 764.6303990036249 771.2909300029278 772.07820700109 773.1498669981956 774.5244399979711 776.4904569983482 778.1442949995399 780.6445659995079 780.6456819996238 786.6359459981322 789.7336810007691 792.48829100281 794.0566800013185 798.2740140035748 811.3146049976349
App start runJsBundle	Baseline Mean: 198.594 ms Stdev: 18.848 ms (9.5%) Runs: 162 170 176 178 180 181 184 185 186 186 187 187 189 193 195 198 200 201 203 204 204 204 205 205 207 212 216 221 223 232 237 244 Current Mean: 209.719 ms Stdev: 19.338 ms (9.2%) Runs: 172 174 182 186 187 192 195 196 196 197 199 201 204 207 209 210 210 210 212 213 217 217 220 226 228 228 230 230 234 235 239 255
App start nativeLaunch	Baseline Mean: 19.968 ms Stdev: 2.055 ms (10.3%) Runs: 17 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 20 21 21 22 22 22 22 24 24 26 Current Mean: 19.967 ms Stdev: 1.871 ms (9.4%) Runs: 18 18 18 18 18 18 18 18 19 19 19 19 19 20 20 20 20 20 20 20 20 20 21 21 21 22 22 24 24 25
App start regularAppStart	Baseline Mean: 0.023 ms Stdev: 0.002 ms (10.2%) Runs: 0.01989799737930298 0.019898004829883575 0.019937999546527863 0.02001900225877762 0.02001900225877762 0.020222999155521393 0.02058900147676468 0.02091500163078308 0.021077997982501984 0.021158993244171143 0.02120000123977661 0.021361999213695526 0.02144400030374527 0.021484993398189545 0.022216998040676117 0.022339001297950745 0.02237999439239502 0.02270500361919403 0.022745996713638306 0.02307099848985672 0.023111999034881592 0.023152999579906464 0.023356005549430847 0.02339700609445572 0.02347799390554428 0.0251460000872612 0.025268003344535828 0.026041999459266663 0.027058005332946777 0.027059003710746765 0.027222000062465668 0.02754800021648407 Current Mean: 0.016 ms Stdev: 0.001 ms (6.4%) Runs: 0.014078997075557709 0.014444999396800995 0.014444999396800995 0.01452600210905075 0.014527000486850739 0.014688998460769653 0.015014998614788055 0.015136003494262695 0.015299998223781586 0.015422001481056213 0.015462003648281097 0.015502996742725372 0.015542998909950256 0.015584997832775116 0.015707001090049744 0.015827998518943787 0.01586899906396866 0.015950001776218414 0.015991002321243286 0.01619499921798706 0.016234993934631348 0.016235001385211945 0.016398005187511444 0.016479000449180603 0.016561001539230347 0.016724005341529846 0.017131000757217407 0.017211996018886566 0.017292998731136322 0.017496995627880096 0.018473006784915924
Open Search Page TTI	Baseline Mean: 618.785 ms Stdev: 13.695 ms (2.2%) Runs: 596.187173999846 596.6221929937601 597.5949310064316 598.3070079982281 598.7677410021424 601.5984710007906 604.9853930026293 607.2191579937935 610.484742000699 612.1805830001831 612.4223629981279 613.0753180012107 614.7706300020218 616.0148120000958 616.3207200020552 618.7763270065188 620.6363120004535 622.3763839974999 623.213704995811 624.0335690006614 624.3382569998503 625.0821129977703 626.665974996984 628.3332519978285 629.8193359971046 633.6761070042849 634.1767989993095 634.228556998074 636.8634850010276 638.5212409943342 640.6867680028081 643.1454680040479 Current Mean: 611.815 ms Stdev: 19.649 ms (3.2%) Runs: 577.7786049991846 580.8572179973125 586.0495200008154 589.9426679983735 590.9179690033197 592.4526780024171 592.5775149986148 596.2236329987645 598.8358149975538 601.0645759999752 603.0716150030494 605.922729998827 606.8017579987645 608.390055000782 608.5031739994884 610.0406500026584 610.3270269930363 610.9978030025959 611.2868660017848 611.8356119990349 617.2020680010319 618.0137539952993 618.8811449930072 619.4569090008736 624.3164070025086 624.7540690004826 627.6752929985523 636.3409420028329 637.0129000023007 651.5574140027165 652.031493999064 656.9501959979534

[yuwenmemon]

MelvinBot checked this as Emergency. Could you explain why it might have done so? Did I forget to check some steps? Did I forget to wait for reviewer checklist?

Ah yes, this is because you merged this PR without a PR reviewer checklist 😅. Good lesson to learn is that you should be waiting until all checks are passing in Github before merging a PR. I think this one is fine to just leave-be, since we do have tests run by @parasharrajat and your changes meet the requirements of what we look for in the PR reviewer checklist.

But yes, for next time do please wait until all tests are passing before ever self-merging a PR. If in doubt, it's always better to have the PR reviewer merge your PR when they feel it's ready anyway.

[OSBotify]

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[parasharrajat]

Yeah, It required approval as well. It was late for me so I wasn't able to do it tomorrow.

[parasharrajat]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

[stitesExpensify]

@stitesExpensify Any thoughts? #15159 (comment)

Apologies, I've been OOO for a few of days. Glad this was resolved!

[yuwenmemon]

Thank you @parasharrajat 🙇

[OSBotify]

🚀 Deployed to production by https://github.com/melvin-bot[bot] in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅