-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: The invalid incorporation date error message doesn't hide after the initial date selection #12288
Conversation
I was getting error building android app. I have asked about it here. I will attach the screenshot once it gets resolved. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well on all platforms
cc: @stitesExpensify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Puneet-here I'm a little confused on this (to be fair, I've probably just forgotten the context or missed a conversation somewhere). Why are we no longer using the incorporationDateFuture and the associated copy?
We were using two functions to check if the entered date is valid.
isValidPastDate can handle the validation alone so we removed the isValidDate function. And the functionality to clear both errors related to date needed to be fixed so instead we decide to just use isValidPastDate for validation and show the error- |
Great, thanks for the explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @stitesExpensify in version: 1.2.23-0 🚀
|
🚀 Deployed to production by @Julesssss in version: 1.2.23-9 🚀
|
Details
#11787 (comment)
Fixed Issues
$ #11787
PROPOSAL: #11787 (comment)
Tests
QA Steps
PR Review Checklist
PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Screen.Recording.2022-10-30.at.11.52.51.PM.mov
Mobile Web - Chrome
Screen.Recording.2022-10-31.at.1.18.18.AM.mov
Mobile Web - Safari
Screen.Recording.2022-10-30.at.11.56.10.PM.mov
Desktop
Screen.Recording.2022-10-30.at.11.54.32.PM.mov
iOS
Screen.Recording.2022-10-31.at.12.39.35.AM.mov
Android