-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send lastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commands
#12162
Send lastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commands
#12162
Conversation
lastModified
with the UpdateWorkspaceCustomUnit
commandslastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commands
lastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commandslastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commands
@youssef-lr requesting you for review since you were PullerBeared on the associated Web-E PR, thanks in advance for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
|
lastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commandslastModified
with the UpdateWorkspaceCustomUnit
and UpdateWorkspaceCustomUnitRate
commands
Now that Web-E #35328 has hit production, removing the hold. Let's get this one merged! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @jasperhuangg in version: 1.2.23-0 🚀
|
🚀 Deployed to production by @Julesssss in version: 1.2.23-9 🚀
|
HELD on: https://github.com/Expensify/Web-Expensify/pull/35328
Fixed Issues
Related to fixing the following offline QA tests
https://github.com/Expensify/Expensify/issues/232202
https://github.com/Expensify/Expensify/issues/232404
Screen.Recording.2022-10-27.at.2.03.53.PM.mov
NOTE: the custom unit value being different after we come back online is a separate issue, most likely related to https://github.com/Expensify/Expensify/issues/229696
Tests and QA
Custom Unit
Custom Unit Rate
PR Review Checklist
PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)