Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default value on picker when data has only 1 element #11819

Merged
merged 4 commits into from
Nov 2, 2022
Merged

set default value on picker when data has only 1 element #11819

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be1b787
set default value on picker when data has only 1 element
aimane-chnaif Oct 13, 2022
4602ce2
add comment of setting default value on picker
aimane-chnaif Oct 14, 2022
4b9978a
add comment of setting default value on picker
aimane-chnaif Oct 14, 2022
5029369
update comment on BasePicker
aimane-chnaif Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/components/Picker/BasePicker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,25 @@ class BasePicker extends React.Component {
super(props);

this.executeOnCloseAndOnBlur = this.executeOnCloseAndOnBlur.bind(this);
this.setDefaultValue = this.setDefaultValue.bind(this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, is it? It will always be in the correct scope already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. can be removed

}

componentDidMount() {
this.setDefaultValue();
}

componentDidUpdate(prevProps) {
if (prevProps.items === this.props.items) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this equality check OK or should it use something a little better like _.isEqual()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need deep comparison here to improve performance.
Because once value is set, don't set again anymore from this code:
if (this.props.value || !this.props.items || this.props.items.length !== 1 || !this.props.onInputChange) {
return;
}

If we use _.isEqual(), it calculates every time this component is rendered (i.e. when value changed), so it affects performance.

return;
}
this.setDefaultValue();
}

setDefaultValue() {
Copy link
Contributor

@sobitneupane sobitneupane Oct 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only set Default Value if number of items is one. So, can you please add a comment mentioning it?

if (this.props.value || !this.props.items || this.props.items.length !== 1 || !this.props.onInputChange) {
return;
}
this.props.onInputChange(this.props.items[0].key);
}

executeOnCloseAndOnBlur() {
Expand Down