-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set default value on picker when data has only 1 element #11819
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
be1b787
set default value on picker when data has only 1 element
aimane-chnaif 4602ce2
add comment of setting default value on picker
aimane-chnaif 4b9978a
add comment of setting default value on picker
aimane-chnaif 5029369
update comment on BasePicker
aimane-chnaif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,26 @@ class BasePicker extends React.Component { | |
this.executeOnCloseAndOnBlur = this.executeOnCloseAndOnBlur.bind(this); | ||
} | ||
|
||
componentDidMount() { | ||
this.setDefaultValue(); | ||
} | ||
|
||
componentDidUpdate(prevProps) { | ||
if (prevProps.items === this.props.items) { | ||
return; | ||
} | ||
this.setDefaultValue(); | ||
} | ||
|
||
setDefaultValue() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We only set Default Value if number of items is one. So, can you please add a comment mentioning it? |
||
// When there is only 1 element in the selector, we do the user a favor and automatically select it for them | ||
// so they don't have to spend extra time selecting the only possible value. | ||
if (this.props.value || !this.props.items || this.props.items.length !== 1 || !this.props.onInputChange) { | ||
return; | ||
} | ||
this.props.onInputChange(this.props.items[0].key); | ||
} | ||
|
||
executeOnCloseAndOnBlur() { | ||
// Picker's onClose is not executed on Web and Desktop, so props.onClose has to be called with onBlur callback. | ||
this.props.onClose(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this equality check OK or should it use something a little better like
_.isEqual()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need deep comparison here to improve performance.
Because once value is set, don't set again anymore from this code:
if (this.props.value || !this.props.items || this.props.items.length !== 1 || !this.props.onInputChange) {
return;
}
If we use
_.isEqual()
, it calculates every time this component is rendered (i.e. when value changed), so it affects performance.