Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 404 page to Help Site #10344

Merged
merged 6 commits into from
Aug 12, 2022
Merged

add 404 page to Help Site #10344

merged 6 commits into from
Aug 12, 2022

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Aug 11, 2022

cc @michelle-thompson

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/216920

Tests

  1. (you need ruby and bundler installed to do this, more info here)

  2. Run:

    cd docs
    bundle install
    bundle exec jekyll serve
  3. Navigate http://localhost:4000/blabla (a non-existent page) and verify the 404 page is displayed

QA Steps

Follow step 2 from the Test section

Screenshots

Web

127 0 0 1_4000_blabla

Mobile Web

@marcochavezf marcochavezf self-assigned this Aug 11, 2022
@marcochavezf marcochavezf changed the title [WIP] add 404 page to Help Site add 404 page to Help Site Aug 11, 2022
@marcochavezf marcochavezf marked this pull request as ready for review August 11, 2022 00:06
@marcochavezf marcochavezf requested a review from a team as a code owner August 11, 2022 00:06
@melvin-bot melvin-bot bot requested review from dangrous and removed request for a team August 11, 2022 00:06
@michelle-thompson
Copy link
Contributor

Looks good to me!

@dangrous dangrous requested a review from a team August 11, 2022 17:25
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team August 11, 2022 17:25
Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just tested this locally and it works like charm.

@techievivek techievivek merged commit 8b0490a into main Aug 12, 2022
@techievivek techievivek deleted the marco-add404page branch August 12, 2022 09:51
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mvtglobally
Copy link

@marcochavezf @techievivek Can you validate this internally or update the QA steps for Staging so we can run it

@marcochavezf
Copy link
Contributor Author

Oops I forgot to update the QA tests with the correct URL, but it's working fine on the production env (https://help.expensify.com/):

Screen Shot 2022-08-16 at 18 21 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants