Start Using BeginSignIn command and remove obsolete API command calls #10222

yuwenmemon · 2022-08-02T23:18:40Z

@robertjchen please review

Details

Start using the BeginSignIn command added in https://github.com/Expensify/Web-Expensify/pull/34408

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/218743

Tests

Do a normal sign-in flow for a user that already has a validated account, make sure it works properly:
https://user-images.githubusercontent.com/4741899/182488142-8044224b-396a-46b2-97a2-69599c0ee76d.mp4

With the same account do the same sign in. Click "Forgot?" on the password form.
Make sure you see the following:
And that you get send a password reset link email.
Click the "Resend link" button.
Make sure you get another email

Sign in with an email that DOES NOT already have an account
Make sure that right away you see:
...And that you get an email with a sign-in link:

Before validating that account by clicking the link in the email, sign-in with that account again, make sure that you get an email with a sign-in link again.

Sign-in with a phone number that does not have an account yet, make sure you see the following:
And that you get a text message with your magic sign-in link:

melvin-bot · 2022-08-02T23:18:45Z

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

luacmartins

Left a few comments. In addition, we have a few places in actions/User.js that still set loading in ONYXKEYS.ACCOUNT. We should update those.

luacmartins · 2022-08-03T16:55:16Z

src/pages/SetPasswordPage.js

@@ -133,7 +120,7 @@ class SetPasswordPage extends Component {
                    <View>
                        <FormAlertWithSubmitButton
                            buttonText={buttonText}
-                            isLoading={this.props.account.loading || this.props.userSignUp.isValidatingEmail}
+                            isLoading={this.props.account.loading}


Should this be isLoading since we are using that now?

Suggested change

isLoading={this.props.account.loading}

isLoading={this.props.account.isLoading}

Do we need to update this one to this.props.account.isLoading?

Yes good catch!

src/pages/signin/ResendValidationForm.js

src/libs/actions/Session/index.js

README.md

src/pages/SetPasswordPage.js

yuwenmemon · 2022-08-03T20:23:17Z

Trying to figure out how the hell I broke 2 unit tests that don't seem related at all 🤔

yuwenmemon · 2022-08-03T23:30:25Z

Okay updated!

luacmartins

Thanks for addressing the comments! Tests are still failing though!

yuwenmemon · 2022-08-04T01:53:46Z

They are not! 😄

robertjchen

Awesome, thanks!!

luacmartins · 2022-08-04T15:12:12Z

src/pages/SetPasswordPage.js

@@ -133,7 +120,7 @@ class SetPasswordPage extends Component {
                    <View>
                        <FormAlertWithSubmitButton
                            buttonText={buttonText}
-                            isLoading={this.props.account.loading || this.props.userSignUp.isValidatingEmail}
+                            isLoading={this.props.account.loading}


Do we need to update this one to this.props.account.isLoading?

yuwenmemon · 2022-08-04T17:32:21Z

Updated again!

OSBotify · 2022-08-04T18:02:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-08-04T21:42:07Z

🚀 Deployed to staging by @luacmartins in version: 1.1.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

yuwenmemon added 7 commits July 28, 2022 18:30

Start using BeginSignIn command in place of GetAccountStatus

cd40818

Merge branch 'main' of github.com:Expensify/App into yuwen-beginSignIn

a7c1730

Merge branch 'main' of github.com:Expensify/App into yuwen-beginSignIn

c2e9cba

Fix forgot password flow

2166e1f

Get rid of uneccessary onyx properties

db643ff

Get rid of User_ReopenAccount

e9bc309

isLoading for password page

886867a

yuwenmemon self-assigned this Aug 2, 2022

yuwenmemon requested a review from a team as a code owner August 2, 2022 23:18

melvin-bot bot requested review from luacmartins and removed request for a team August 2, 2022 23:19

yuwenmemon added 6 commits August 2, 2022 16:22

Espanol

7e37c2a

Remove CreateAccount

97115c8

Update tests

fd76fc2

Merge branch 'main' of github.com:Expensify/App into yuwen-beginSignIn

93d7617

Make sure login in test helper matches login in test

238465d

Merge branch 'main' of github.com:Expensify/App into yuwen-beginSignIn

4e3a4d2

luacmartins requested changes Aug 3, 2022

View reviewed changes

robertjchen requested changes Aug 3, 2022

View reviewed changes

src/pages/SetPasswordPage.js Outdated Show resolved Hide resolved

yuwenmemon added 3 commits August 3, 2022 11:39

PR comments

f72ce58

Merge branch 'main' of github.com:Expensify/App into yuwen-beginSignIn

fca6e57

verifying Account -> validating Account

5448b96

yuwenmemon added 2 commits August 3, 2022 14:15

Fix test

cf3a61a

make better usage of mockImplementation calls

f0c43b0

luacmartins reviewed Aug 3, 2022

View reviewed changes

JS style

812363f

robertjchen previously approved these changes Aug 4, 2022

View reviewed changes

luacmartins requested changes Aug 4, 2022

View reviewed changes

yuwenmemon added 2 commits August 4, 2022 10:23

Merge branch 'main' of github.com:Expensify/App into yuwen-beginSignIn

2bb0f2f

loading -> isLoading

3141a4d

yuwenmemon dismissed robertjchen’s stale review via 3141a4d August 4, 2022 17:27

luacmartins approved these changes Aug 4, 2022

View reviewed changes

luacmartins merged commit f3c831d into main Aug 4, 2022

luacmartins deleted the yuwen-beginSignIn branch August 4, 2022 17:56

OSBotify mentioned this pull request Aug 4, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

This was referenced Aug 5, 2022

Revert "Start Using BeginSignIn command and remove obsolete API command calls" #10266

Merged

Start Using BeginSignIn command and remove obsolete API command calls (Take 2) #10269

Merged

flodnv mentioned this pull request Aug 17, 2022

Login - When entering 2 digits, the wrong message is displayed #10430

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start Using BeginSignIn command and remove obsolete API command calls #10222

Start Using BeginSignIn command and remove obsolete API command calls #10222

yuwenmemon commented Aug 2, 2022

melvin-bot bot commented Aug 2, 2022

luacmartins left a comment

luacmartins Aug 3, 2022

luacmartins Aug 4, 2022 •

edited

Loading

yuwenmemon Aug 4, 2022

yuwenmemon commented Aug 3, 2022

yuwenmemon commented Aug 3, 2022

luacmartins left a comment

yuwenmemon commented Aug 4, 2022

robertjchen left a comment

luacmartins Aug 4, 2022 •

edited

Loading

yuwenmemon commented Aug 4, 2022

OSBotify commented Aug 4, 2022

OSBotify commented Aug 4, 2022

	isLoading={this.props.account.loading}
	isLoading={this.props.account.isLoading}

Start Using BeginSignIn command and remove obsolete API command calls #10222

Start Using BeginSignIn command and remove obsolete API command calls #10222

Conversation

yuwenmemon commented Aug 2, 2022

Details

Fixed Issues

Tests

melvin-bot bot commented Aug 2, 2022

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins Aug 3, 2022

Choose a reason for hiding this comment

luacmartins Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

yuwenmemon Aug 4, 2022

Choose a reason for hiding this comment

yuwenmemon commented Aug 3, 2022

yuwenmemon commented Aug 3, 2022

luacmartins left a comment

Choose a reason for hiding this comment

yuwenmemon commented Aug 4, 2022

robertjchen left a comment

Choose a reason for hiding this comment

luacmartins Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

yuwenmemon commented Aug 4, 2022

OSBotify commented Aug 4, 2022

OSBotify commented Aug 4, 2022

luacmartins Aug 4, 2022 •

edited

Loading

luacmartins Aug 4, 2022 •

edited

Loading