[HOLD for payment 2022-07-05] [$250] On request call page keyboard type is wrong for phone number, extension field - reported by @Tushu17

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open mobile Website/App
2. Go to workspace > Get assistance > Request a setup call.
3. Touch on Phone Number/Extension input field.

Expected Result:

You should see a number pad.

Actual Result:

It shows normal alphabetical keyboard.

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Mobile Web

Version Number: 1.1.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-05-23.at.10.51.55.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1653329809177109

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Tushu17]

Proposal

We just need to add keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD} in TextInput of Phone number & Extension field.

App/src/pages/RequestCallPage.js

Lines 301 to 303 in 6bac9af

	<TextInput
	label={this.props.translate('common.phoneNumber')}
	name="phone"

App/src/pages/RequestCallPage.js

Lines 311 to 314 in 6bac9af

	<TextInput
	label={this.props.translate('requestCallPage.extension')}
	autoCompleteType="off"
	autoCorrect={false}

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[danieldoglas]

Ok, this can be external

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MitchExpensify]

Upwork job

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@thienlnam I like @Tushu17's proposal.

🎀 👀 🎀 C+ reviewed

[allroundexperts]

@rushatgabhane Is it allowed to make a proposal before even a job is declared external?

[rushatgabhane]

@allroundexperts good question!
As per CONTRIBUTING.md you can. But Expensify has the right to use your proposal without compensation if it isn't marked External.

Note: Issues that have not had the External label applied have not yet been approved for implementation. This means, if you propose a solution to an issue without the External label (which you are allowed to do) it is possible that the issue will be fixed internally. If the External label has not yet been applied, Expensify has the right to use your proposal to fix said issue, without providing compensation for your solution. This process covers the very rare instance where we need or want to fix an issue internally.

[allroundexperts]

@allroundexperts good question! As per CONTRIBUTING.md you can. But Expensify has the right to use your proposal without compensation if it isn't marked External.

Note: Issues that have not had the External label applied have not yet been approved for implementation. This means, if you propose a solution to an issue without the External label (which you are allowed to do) it is possible that the issue will be fixed internally. If the External label has not yet been applied, Expensify has the right to use your proposal to fix said issue, without providing compensation for your solution. This process covers the very rare instance where we need or want to fix an issue internally.

Gotcha. Thanks!

[melvin-bot]

📣 @Tushu17 You have been assigned to this job by @thienlnam!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Tushu17]

I have made the PR

[thienlnam]

PR merged, pending regression testing

[MitchExpensify]

Hired @Tushu17 & @rushatgabhane for eventual payment

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.78-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix keyboard type #9486

If no regressions arise, payment will be issued on 2022-07-05. 🎊

[MitchExpensify]

Paying tomorrow when back from ooo!

[MitchExpensify]

Paid, contracts ended, closing!