Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] [$500] Height of dropdown menu increases - reported by @thesahindia #8719

Closed
mvtglobally opened this issue Apr 21, 2022 · 56 comments
Closed

[HOLD] [$500] Height of dropdown menu increases - reported by @thesahindia #8719

mvtglobally opened this issue Apr 21, 2022 · 56 comments
Assignees
@parasharrajat @neil-marcellini @adelekennedy
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open a chat
  2. Click on actions > send money > add amount and click the next button
  3. Now click on the dropdown arrow while the keyboard is open

Expected Result:

Height of dropdown menu should remain same

Actual Result:

Height of dropdown menu increases

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.56-0
Reproducible in staging?: y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenrecording_20220402_122402.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648882929562619

View all open jobs on GitHub
@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Apr 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 21, 2022

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 21, 2022
@jboniface jboniface removed their assignment Apr 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 21, 2022

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2022
@tylerkaraszewski
Copy link
Contributor

Seems legit and external.

@melvin-bot melvin-bot bot removed the Overdue label Apr 26, 2022
@tylerkaraszewski tylerkaraszewski removed their assignment Apr 26, 2022
@tylerkaraszewski tylerkaraszewski added the External Added to denote the issue can be worked on by a contributor label Apr 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@adelekennedy
Copy link

Internal
External

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Triggered auto assignment to @neil-marcellini (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Height of dropdown menu increases - reported by @thesahindia [$250] Height of dropdown menu increases - reported by @thesahindia Apr 26, 2022
@akhilesh-mourya
Copy link

Hello @mvtglobally, the dropdown height issue seems to be happening due to improper handling of the dropdown open animation start time delay. UI usually shows this kind of issue where two animations are happening together at the same time. In our case, the keyboard is closing and the dropdown is opening at the same time.

I can fix this issue.

@parasharrajat
Copy link
Member

Hi @akhilesh-mourya, Could you please share your proposal? Were you able to reproduce this issue?

@neil-marcellini
Copy link
Contributor

@parasharrajat I'm new to CME, is there anything we can do here to get more eyes on this, or another response, or do we keep waiting?

@parasharrajat
Copy link
Member

Waiting...😅

@adelekennedy adelekennedy added Monthly KSv2 and removed Weekly KSv2 labels Jul 14, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2022
@neil-marcellini
Copy link
Contributor

@parasharrajat what's the status on the withWindowDimensions bug?

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2022
@parasharrajat
Copy link
Member

That is still not merged into our app but progressing slowly.

@adelekennedy
Copy link

Still holding here!

@melvin-bot melvin-bot bot added the Overdue label Oct 10, 2022
@adelekennedy
Copy link

Still on hold - @parasharrajat @neil-marcellini any updates I should make here?

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2022
@neil-marcellini
Copy link
Contributor

The withWindowDimensions work around has been removed here #9143, so as I understand it this should be fixed now? I'll see if I can reproduce it.

@neil-marcellini
Copy link
Contributor

The PR I linked above hasn't been deployed to staging or prod yet, but from local testing it looks like it will fix this issue. It looks like there's another bug where the pay button isn't visible above the keyboard and when I scroll down I can scroll too far. I will report that issue unless I find an existing issue.

Simulator.Screen.Recording.-.iPhone.13.-.2022-10-10.at.09.38.22.mp4

@neil-marcellini
Copy link
Contributor

I'm making this weekly so I remember to test again and close the issue once the fix hits prod.

@neil-marcellini neil-marcellini added Weekly KSv2 and removed Monthly KSv2 labels Oct 11, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2022
@srikarparsi srikarparsi removed their assignment Oct 19, 2022
@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2022
@neil-marcellini
Copy link
Contributor

This issue is fixed!

RPReplay_Final1666972925.MP4

Here is the issue I created for the other bug #11722

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2022
@thesahindia
Copy link
Member

I believe it's eligible for the reporting compensation.

cc: @adelekennedy @neil-marcellini

@thesahindia
Copy link
Member

bump @adelekennedy

@thesahindia
Copy link
Member

Bump @adelekennedy ^

@adelekennedy
Copy link

@thesahindia whoops! Hired you fro the reporting bonus

@thesahindia
Copy link
Member

Thanks, accepted!

@thesahindia
Copy link
Member

Bump @adelekennedy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parasharrajat parasharrajat

@neil-marcellini neil-marcellini

@adelekennedy adelekennedy

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests