Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] BUG: Pay button is not visible above the keyboard on the IOU confirmation page #11722

Closed
neil-marcellini opened this issue Oct 11, 2022 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Oct 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign in with any account
  2. If needed, start a chat with someone other than concierge by clicking the green plus, New chat, typing in a valid email, and selecting that person.
  3. Click the plus at the bottom left, Send money
  4. Enter an amount and hit next

Expected Result:

The pay button appears above the keyboard

Actual Result:

The pay button is hidden below the keyboard and there is extra gray space below it.

Workaround:

Scroll down and click the button, ignore the ugly space below it.

Platform:

Where is this issue occurring?

  • Mobile Web iOS / Safari
  • Android / Chrome?

Version Number: v1.2.11-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/26260477/194914536-aa182e74-6c8a-4162-9fe0-3f6203337e7d.mp4
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation:

View all open jobs on GitHub

@neil-marcellini neil-marcellini added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Oct 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2022

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 11, 2022
@bfitzexpensify bfitzexpensify removed their assignment Oct 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@ctkochan22 ctkochan22 added Improvement Item broken or needs improvement. External Added to denote the issue can be worked on by a contributor labels Oct 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to @conorpendergrast (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to @mountiny (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title BUG: Pay button is not visible above the keyboard on the IOU confirmation page [$250] BUG: Pay button is not visible above the keyboard on the IOU confirmation page Oct 12, 2022
@mountiny mountiny added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Oct 12, 2022
@mountiny mountiny changed the title [$250] BUG: Pay button is not visible above the keyboard on the IOU confirmation page [HOLD App#10273] [$250] BUG: Pay button is not visible above the keyboard on the IOU confirmation page Oct 12, 2022
@mountiny
Copy link
Contributor

I am removing the Help Wanted label and putting this on hold for #10273

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@mountiny mountiny added Monthly KSv2 and removed Weekly KSv2 labels Oct 21, 2022
@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2022
@mountiny
Copy link
Contributor

Still on hold

@tgolen tgolen changed the title [HOLD App#10273] [$250] BUG: Pay button is not visible above the keyboard on the IOU confirmation page [$250] BUG: Pay button is not visible above the keyboard on the IOU confirmation page Oct 31, 2022
@tgolen tgolen self-assigned this Oct 31, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 31, 2022

This is no longer on hold and can have proposals created for it with the new code.

@mountiny mountiny added Weekly KSv2 and removed Monthly KSv2 labels Oct 31, 2022
@mountiny
Copy link
Contributor

Making this Weekly an waiting for proposals, unassigned, Tim and Kosuke as I was assigned by the External label.

Waiting for proposals.

@kbecciv @mvtglobally Can you please confirm this is still reproducible?

@tgolen tgolen self-assigned this Oct 31, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 31, 2022

@vitHoracek I wanted to keep this assigned to me so I could keep an eye on the proposals to ensure they are not hacks or workarounds with some of the foundational changes I made. I'll let you lead this issue, but I'll just be lurking in the background.

@mountiny
Copy link
Contributor

@tgolen No problem, thank you for clarifying! 🙌

@JmillsExpensify
Copy link

@conorpendergrast Given that we're still early and no proposals have been accepted, I'm assigning myself per the new BZ process: https://stackoverflow.com/c/expensify/questions/14597/14598#14598.

@JmillsExpensify
Copy link

Btw, we still need this issue tested, thanks Applause!

@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels Nov 4, 2022
@mountiny
Copy link
Contributor

mountiny commented Nov 4, 2022

I can reproduce only on mobile web as mentioned, works fine in iOS.

Waiting fro proposals

@JmillsExpensify
Copy link

@vitHoracek for clarity, did you test on Android?

@mountiny
Copy link
Contributor

mountiny commented Nov 6, 2022

@JmillsExpensify nope, only on iOS. Dont own Android, but thinking of getting some troubleshooting.

@JmillsExpensify
Copy link

Ok thanks! I just confirmed on iOS as well. The pay button doesn't appear above the keyboard.

Contributors - this issue is open for proposals. Related Upwork job is here: https://www.upwork.com/jobs/~01092b6ed16494aaaa.

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Nov 6, 2022

This is working fine in Android!

Screen_Recording_20221107-015318_Chrome.mp4

This issue is a common issue that occurs on most screens not just on this page.

@JmillsExpensify
Copy link

Thank you for stepping in and helping confirm on Android! In fact, I just realized that this issue is a dupe of #10670. I'm going to close this issue and add these testing steps to the linked issue. We can continue working through things there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

9 participants