[HOLD for payment 2022-05-26] [$250] Feature Request: Profile picture, names should be tappable at beginning of the chat & group or channel - reported by @Santhosh-Sellavel

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

Improving UX when a new chat, group, or room is created. Since we have only a couple of chats & this welcome message.

• Profile picture expected to be tappable
• Highlighted users or room names are expected to be tappable/hoverable.
• In mobile, it makes it even easier to navigate to details.

Solution:

Make them tappable. Tapping Picture should navigate the Report Details page. Tapping on user name should navigate user details straight away even if it's group chat.

Action Performed:

Open a new chat
At beginning of the chat, the User profile and name is shown in the message
Try to hover over the user name, also try to click on it.

Expected Result:

On clicking should navigate to the report details or user details page.

Actual Result:

Nothing happens

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-03-09.at.11.55.53.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646854800592179?thread_ts=1646851420.965439&cid=C01GTK53T8Q

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @miljakljajic (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

Issue LGTM, labelling as external.

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Tushu17]

Proposal

I think we can just wrap RoomHeaderAvatar and ReportWelcomeText with Pressable like we have in HeaderView.js -

App/src/pages/home/HeaderView.js

Lines 127 to 135 in 2969ed7

	<Pressable
	onPress={() => {
	if (isChatRoom || isPolicyExpenseChat) {
	return Navigation.navigate(ROUTES.getReportDetailsRoute(props.report.reportID));
	}
	if (participants.length === 1) {
	return Navigation.navigate(ROUTES.getDetailsRoute(participants[0]));
	}
	Navigation.navigate(ROUTES.getReportParticipantsRoute(props.reportID));

App/src/pages/home/report/ReportActionItemCreated.js

Lines 37 to 42 in 2969ed7

	<RoomHeaderAvatars
	avatarIcons={avatarIcons}
	shouldShowLargeAvatars={isPolicyExpenseChat}
	/>
	<ReportWelcomeText report={props.report} />
	</View>

If we wrap RoomHeaderAvatar and ReportWelcomeText together in the same Pressable it will make the whole area clickable so we can make a function for onPress and we can wrap them individually and can pass the function to their parent Pressable

[jliexpensify]

Posted!

Internal - https://www.upwork.com/ab/applicants/1506393001208500224/job-details
External - https://www.upwork.com/jobs/~01eb2ca968028a8234

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

📣 @rushatgabhane You have been assigned to this job by @melvin-bot[bot]!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Current assignee @chiragsalian is eligible for the Exported assigner, not assigning anyone new.

[rushatgabhane]

🎀 👀 🎀 C+ reviewed

@Tushu17's proposal should get the job done.
cc: @chiragsalian

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Current assignee @chiragsalian is eligible for the Exported assigner, not assigning anyone new.

[chiragsalian]

I'll manually assign @Santhosh-Sellavel to this one. @Santhosh-Sellavel, if your plate is full and you can't take this let me know 🙂

[Santhosh-Sellavel]

I see a PR for this issue & why @chiragsalian did you add a help wanted label.

Are we looking for proposals?

[chiragsalian]

Oh because i'd like you to take over reviewing #8409 as well since rushat is OOO. Is that alright by you?

[Santhosh-Sellavel]

Yeah fine remove Help Wanted label!

[jliexpensify]

Removed!

[Santhosh-Sellavel]

Seems the PR is ready for review. Mostly looks good, will test it out by tomorrow.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• make avatar and welcome message pressable #8409

If no regressions arise, payment will be issued on 2022-05-26. 🎊

[Christinadobrzyn]

Here's the job that will be paid. Can we confirm, that payment for this will be:

@Tushu17 for the fix
@Santhosh-Sellavel for reporting and C+

[Christinadobrzyn]

Sorry for the ping but @chiragsalian I noticed there were some other PRs mentioned after this issue deployed to production. Can you confirm we're good to pay this or are there any regressions/issues that need to be fixed?

I think those are different issues but just checking.

[chiragsalian]

Yes the PR has been live for 8 days with no issues.
Feel free to process the payments 🙂

[Christinadobrzyn]

Alright, closed the job in Upwork.

Paid @Tushu17 $250 for the fix
Paid @Santhosh-Sellavel $250 for C+ and $250 for a reporting bonus