[HOLD for payment 2022-03-02] After you transfer your balance the wallet page doesn't automatically update

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From account A transfer balance to Account B
2. Login to account B and check balance
3. Refresh

Expected Result:

Account balance should update after transfer is made

Actual Result:

After you transfer your balance the wallet page doesn't automatically update

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.36-0
Reproducible in staging?:
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2022-02-07_15-16-21.mp4

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643563169531119

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[zanyrenney]

triage complete -- looks like they already tagged with eng, so not reapplying the label again now.

[bondydaa]

Hmm I'm not super familiar with this code to know off hand if this is a client issue (maybe onyx isn't being updated properly) or an API issue (maybe we're not returning the updated balance properly) so I can't tell if this is external or not. I'll take a look and see what I can find out.

[parasharrajat]

There are a couple of issues here.

1. First, no confirmation modal is shown after completion.
2. Second, balance is not updated.

[bondydaa]

alrighty looks like the API doesn't return anything back to the client https://github.com/Expensify/Web-Expensify/blob/5988e0dc06223c766c5f57b4eea4773963802654/api.php#L2279-L2280

Personally I think we probably should just update the API to return the remaining balance so that we don't have to then just make another call to the API to get the balance but 🤷 seems like it was built this way on purpose.

I think the bug is that here:

App/src/libs/actions/PaymentMethods.js

Line 203 in 56c97f4

Onyx.merge(ONYXKEYS.USER_WALLET, {balance: 0});

we set the balance key on the USER_WALLET but looking at the rest of the code we refer to currentBalance when trying to render the balance:

Expensidev/App (main) $ ack -Q .currentBalance
src/components/CurrentWalletBalance.js
43:        props.userWallet.currentBalance / 100, // Divide by 100 because balance is in cents

src/pages/settings/Payments/TransferBalancePage.js
177:        const calculatedFee = PaymentUtils.calculateWalletTransferBalanceFee(this.props.userWallet.currentBalance, selectedPaymentType);
178:        const transferAmount = this.props.userWallet.currentBalance - calculatedFee;

src/pages/settings/InitialSettingsPage.js
125:        props.userWallet.currentBalance / 100, // Divide by 100 because balance is in cents

[bondydaa]

looks like it was added in this PR #6878

[parasharrajat]

Oh, yeah. You are correct. I added this code and this should be currentBalance.

[MelvinBot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[bondydaa]

coolio throwing the external label and un-assigning myself, fix seems simple enough 👍

[parasharrajat]

Proposal

1. Change the

   App/src/libs/actions/PaymentMethods.js

   Line 203 in 56c97f4

   Onyx.merge(ONYXKEYS.USER_WALLET, {balance: 0});

   to set currentBalance to 0.

Confirmation Modal is shown correctly. The linked video was recorded on the web info

This fixes the linked issue.

[kadiealexander]

Posted to Upwork! https://www.upwork.com/jobs/~012f263a77525f0ae0

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

I would like to fix this via proposal @NikkiWines

[NikkiWines]

Yep, @parasharrajat's proposal looks good! 👍

[parasharrajat]

PR will be live shortly.

[NikkiWines]

@kadiealexander can you hire @parasharrajat for this job please. TY!

[kadiealexander]

Hired! Thanks @parasharrajat :)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: reset the wallet balance when transfer is successful #7681

If no regressions arise, payment will be issued on 2022-03-02. 🎊

[kadiealexander]

Paid! Thanks @parasharrajat 😊