-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] iOS - IOU - "Not here" error appears briefly after deleting expense #50085
Comments
Triggered auto assignment to @tgolen ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I don't think this needs to be a blocker. I cannot find anything listed in the deploy checklist that stands out to me, so I am going to move this to be external and get some help trying to find what caused it and a solution. |
Job added to Upwork: https://www.upwork.com/jobs/~021841519823485482301 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
Triggered auto assignment to @isabelastisser ( |
Edited by proposal-police: This proposal was edited at 2024-10-03 04:45:01 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue."Not here" error appears briefly after deleting expense What is the root cause of that problem?After deleting the expense, this App/src/pages/ReportDetailsPage.tsx Line 719 in e61ee7f
And after calling the delete expense function, it will navigate back to the previous screen, where the App/src/pages/home/ReportScreen.tsx Lines 270 to 276 in e61ee7f
The condition shows the 'Not here' page in this issue App/src/pages/home/ReportScreen.tsx Line 392 in e61ee7f
What changes do you think we should make in order to solve the problem?We prevent updating wasReportAccessibleRef after completing the navigation back to avoid showing the 'Not Here' page, something like this: // .src/pages/home/ReportScreen.tsx#L270
useEffect(() => {
+ InteractionManager.runAfterInteractions(() => {
+ requestAnimationFrame(() => {
if (!report?.reportID || shouldHideReport) {
wasReportAccessibleRef.current = false;
return;
}
wasReportAccessibleRef.current = true;
+ });
+ });
}, [shouldHideReport, report]); Or we could delay navigating back in POC
Screen.Recording.2024-10-03.at.11.16.58.movREPRODUCED THIS ISSUE: Screen.Recording.2024-10-03.at.11.18.21.mov |
ProposalPlease re-state the problem that we are trying to solve in this issue."Not here" error appears briefly after chenging expense date and deleting it after What is the root cause of that problem?
App/src/pages/home/ReportScreen.tsx Line 272 in e61ee7f
where we set What changes do you think we should make in order to solve the problem?
App/src/pages/home/ReportScreen.tsx Line 272 in e61ee7f
What alternative solutions did you explore? (Optional) |
@getusha, please review the proposals above. Thanks! |
@mkzie2 i am still able to reproduce the issue after applying your solution Screen.Recording.2024-10-06.at.8.27.54.in.the.morning.mov |
@getusha Can you provide steps to reproduce the bug, or try refreshing your browser to ensure the changes are applied? I tested the solution on my end, and it works as expected. Here’s a slowed-down version to demonstrate: after deleting an expense, the skeleton page appears instead of the 'Not here' page: Screen.Recording.2024-10-06.at.13.18.10.mov |
Hi @getusha , POC
Screen.Recording.2024-10-06.at.21.28.53.mov |
@getusha, can you please provide an update? Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@mkzie2 just follow the steps in this issue, i am still able to reproduce it with your solution just like @huult did #50085 (comment) |
@huult could you track down which PR reintroduced this issue? |
@getusha Sorry, please correct me if I was wrong, but I cannot see any "Not here" page in this video. |
@getusha this happend by this PR. This happend by this change. Steps to test:
You will see the changes, and this issue will occur |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): andreylazutkinutest+02102@gmail.com
Issue reported by: Applause - Internal Team
Issue found when executing PR #49878
Action Performed:
Expected Result:
I should be able to delete it without any errors
Actual Result:
"Not here" error appears briefly after chenging expense date and deleting it after
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6622222_1727881924347.HABH7257.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @getushaThe text was updated successfully, but these errors were encountered: