Contact methods - Not here page opens after adding existing contact and dismissing error

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #48320
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings.
3. Go to Profile > Contact methods.
4. Click New contact method.
5. Enter an existing email > Next.
6. Enter magic code > Next.
7. Click on the added existing email.
8. Click X button.

Expected Result:

App will return to the previous page after dismissing the error.

Actual Result:

Not here page opens after adding existing contact and dismissing error.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6591245_1725324057324.20240903_083651.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01263340c168620229
• Upwork Job ID: 1830946896292368627
• Last Price Increase: 2024-09-03

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens after adding existing contact and dismissing the error

What is the root cause of that problem?

on closing the error, it removes the current email and doesn't go back to the previous page so that's why it shows not here

What changes do you think we should make in order to solve the problem?

we should add go back to the contacts page on closing the error, the same as we do when removing a contact

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

Line 209 in 0a2c0b2

onClose={() => User.clearContactMethod(contactMethod)}

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal


Regression from #48320

Please re-state the problem that we are trying to solve in this issue.

Contact methods - Not here page opens after adding existing contact and dismissing error

What is the root cause of that problem?

When isFailedAddContactMethod is true the Existing account error message is shown. And when we close the error message, User.clearContactMethod(contactMethod) is called which will remove the optimistic contact method and then not here page will be shown.

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

Lines 205 to 212 in 0a2c0b2

	{isFailedAddContactMethod && (
	<ErrorMessageRow
	errors={ErrorUtils.getLatestErrorField(loginData, 'addedLogin')}
	errorRowStyles={[themeStyles.mh5, themeStyles.mv3]}
	onClose={() => User.clearContactMethod(contactMethod)}
	canDismissError
	/>
	)}

What changes do you think we should make in order to solve the problem?


We should call Navigation.goBack(ROUTES.SETTINGS_CONTACT_METHODS.getRoute(backTo) before we call User.clearContactMethod(contactMethod).

What alternative solutions did you explore? (Optional)

Result

Monosnap.screencast.2024-09-03.16-07-19.mp4

[abzokhattab]

Proposal updated

corrected the url but the same solution approach is used

[Krishna2323]

Proposal Updated

• Added result video

[MariaHCD]

This looks like a regression from #48320

@hungvu193 @mollfpr can you handle the fix for this since we're still in the regression period.

[hungvu193]

Cc @getusha

[MariaHCD]

Oh, actually from this comment, we already identified this bug before merging: #48320 (review)

@getusha Could you look into the fixing the navigation when the user removes the optimistic login? The page goes to not found page because the contact method is in the URL. I think we need to redirect to the contact method list page

[MariaHCD]

@getusha Let's fix this as a follow up improvement :)

[hungvu193]

This looks like a regression from #48320

@hungvu193 @mollfpr can you handle the fix for this since we're still in the regression period.

Please assign me and @getusha. We will handle this one

[mountiny]

Yeah, this was known, but we moved ahead with this because it's an important fix for a fire. I dont think this has to bea deploy blocker as this is just a minor UX issue the user can get out of easily and @getusha can follow up with the fix

Happy to take over this one @MariaHCD

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01263340c168620229

[melvin-bot]

Current assignees @hungvu193 and @getusha are eligible for the External assigner, not assigning anyone new.

[getusha]

@mountiny @hungvu193 PR is ready for both issues

[mountiny]

No extra payments will be required for this one as we will handle it bundled up with the original PR

[isabelastisser]

@mountiny, can I close this one?

[mountiny]

I think so yes