[HOLD for payment 2024-08-09] Room - System message shows code when adding emoji and mark down to room description

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to a room.
3. Click on the room header.
4. Click Room description.
5. Enter an emoji, text with mark down and save it.
6. Go back to room chat.

Expected Result:

Room description system message will not show code when adding emoji and text with mark down to room description.

Actual Result:

Room description system message shows code when adding emoji and text with mark down to room description.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6556785_1722292620046.20240730_063624.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room description system message shows code when adding emoji and text with mark down to room description.

What is the root cause of that problem?

We did not cover the case of description being HTML, we just render plain text:

App/src/libs/ReportActionsUtils.ts

Line 1588 in 3418820

return `${Localize.translateLocal('roomChangeLog.updateRoomDescription')} ${originalMessage?.description}`;

App/src/pages/home/report/ReportActionItem.tsx

Lines 649 to 651 in 7ae492e

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {
	const message = ReportActionsUtils.getUpdateRoomDescriptionMessage(action);
	children = <ReportActionItemBasicMessage message={message} />;

What changes do you think we should make in order to solve the problem?

Add a new prop to ReportActionItemMessage: shouldRenderHTML where if it is, return RenderHTML:

if (shouldRenderHtml) {
    return (
        <View>
            <RenderHTML html={`<comment><muted-text>${message}</muted-text></comment>`} />
        </View>
    )
}

Toggle shouldRenderHTML for update room description report action:

App/src/pages/home/report/ReportActionItem.tsx

Lines 649 to 651 in 7ae492e

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {
	const message = ReportActionsUtils.getUpdateRoomDescriptionMessage(action);
	children = <ReportActionItemBasicMessage message={message} />;

[Julesssss]

I don't see any changes to the API or Auth command in the last 3 months, so I'm leaning towards App. I see some potential PRs that may have caused the regression:

• Bump expensify-common to v2.0.57 #46321
• Emojis larger in other contexts than just single character messages #40692
• Fixed task description when edit second time 42660 #43084

[Julesssss]

Not a blocker, updating room names is not worth holding the release

[gijoe0295]

@Julesssss Update room description system message was added in #45986. It's the offending PR as explained in my proposal.

[Julesssss]

Thanks @gijoe0295. We haven't got to the proposal stage yet, but we can compensate if this solution is used. I am asking the author to fix with a follow-up PR.

[nkdengineer]

@Julesssss I will raise a PR soon.

[nkdengineer]

@hungvu193 @Julesssss we have a follow PR here

[Julesssss]

PR merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: System message shows code when adding emoji in room description #46512

If no regressions arise, payment will be issued on 2024-08-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Julesssss] The PR that introduced the bug has been identified. Link to the PR:
• [@Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Julesssss] Determine if we should create a regression test for this bug.
• [@Julesssss] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[slafortune]

Fixed internally - closing