[$250] QBO - Connection options are missing in QBO connection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to the app with a new expensifail account
2. Create a new workspace
3. Go to more features > enable accounting
4. Navigate to the accountings page and connect with QBO
5. When you are navigated to the QBO page enter the credentials and finish the connection
6. After connecting with QBO, you will be navigated to the app
7. Wait for the connection to sync

Expected Result:

QBO options (Import, Export, Card reconciliation and Advanced options) are displayed

Actual Result:

QBO options (Import, Export, Card reconciliation, and Advanced options) are not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556582_1722281658856.2024-07-29_22_24_02.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ishpaul777

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841525897082466980
• Upwork Job ID: 1841525897082466980
• Last Price Increase: 2024-10-09

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[tgolen]

@kosmydel @hungvu193 @arosiclair Is it possible this is related to #44733 ?

[arosiclair]

I don't think so. Those changes should only affect report exports.

[chiragsalian]

Not a web-e blocker as discussed here

[tgolen]

Sounds like @yuwenmemon might know what's happened here and he will be looking into it.

[yuwenmemon]

Weird, not able to reproduce this in Dev

[yuwenmemon]

Oh I see it now. @NikkiWines it looks like this is because we initially set the lastSync isConnected property to false:
https://github.com/Expensify/Integration-Server/commit/a4cca1bb4863dfcbe9c566cbeeaa47d5676c8c72#diff-49d9c0cf9775a8c0d9890e99f5085ddbed36dbe92d1d8ec3a3956e50d5d9a555R27

[yuwenmemon]

I think this will need to be fixed via the IS.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[hungvu193]

@yuwenmemon I can reproduce this issue.
As I checked the logs, Pusher events never seem to push updates after QBO was connected until the next manual sync (I tried to logout and login again but it didn't work).

If we show a loading when credentials are not empty and data is empty, it will load infinitely. So I think in this case, if we don't update the BE, we should change the FE behavior for QBO.

If

Specifically for QuickBooks Online, the case would be if we see quickbooksOnline.config.credentials but not quickbooksOnline.data

We should let users know that they need to do another sync ( or we can do it inside PolicyAccount with an useEffect).
What do you think 🤔 ?

[trjExpensify]

I don't think we want to ask them to do a manual sync just after connecting for the first time. That seems like a bad design, so can we trigger that if necessary?

[hungvu193]

Cool. Agreed. I'll post a proposal based on my idea above

[ishpaul777]

not overdue, waiting for proposals

[hungvu193]

While working on proposal, I realized this issue was fixed. Is there anyone here can reproduce it? 😂

[trjExpensify]

Don't you have to simulate a crappy network and delay thejobDone event as Yuwen did here?

[hungvu193]

Don't you have to simulate a crappy network and delay thejobDone event as Yuwen did here?

In this comment, I'm seeing Yuwen is debugging in his local BE env, I'm not sure if I can replicate with only my local FE setup 😨

[yuwenmemon]

@hungvu193 I'm happy to work with you to test any solution you drum up with my debugger setup.

[hungvu193]

@hungvu193 I'm happy to work with you to test any solution you drum up with my debugger setup.

Sure thing. But I wonder if anyone can still reproduce this issue? I can reproduce it easily a few days ago. However, I can't reproduce it now.

[ishpaul777]

wonder if anyone can still reproduce this issue?

i'll try reproducing in few hours today

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ishpaul777]

was not able to reproduce the options came as soon as sync completed (staging v9.0.46-4)

Screen.Recording.2024-10-09.at.10.57.05.PM.mov

[hungvu193]

@trjExpensify can you request QA to retest this one? If they can't reproduce then I think we can close this one

[yuwenmemon]

I can still reproduce this (notice the moment when I move the mouse a lot - you can still see a split second where we have the connection options missing but the sync has "finished"):

Kapture.2024-10-10.at.17.36.02.mp4

Like I said in my earlier post, I'm happy to work with anyone who has a proposal / branch to test if their solution solves what I'm seeing.

[aldo-expensify]

I can still reproduce this (notice the moment when I move the mouse a lot - you can still see a split second where we have the connection options missing but the sync has "finished"):

but... is that a bug? I would be concern if the menu options don't ever appear.. but if they have such a small delay 🤷

[aldo-expensify]

I have something kind of related here: #49372, but opposite? Opposite because the menu options appear too soon.

I think the problem in my issue is that we show the options but we still load some data after... so if you are quick in changing something it may get reverted.

[yuwenmemon]

Well, if something were to happen where, for whatever reason, the Push notification came from the IS for the job to be done but the data from the sync did not, it would be more severe.

I agree, though; the small flash is not the worst bug in the world. However, it's still a bug nevertheless.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

QBO - Connection options are missing in QBO connection

What is the root cause of that problem?

As described above, the RCA of this issue is race condition and sits at the heart of how the new connection with Onyx updates works. Our FE received jobDone event from our Pusher event, even when we didn't have lastDate data yet, so we will see the Last synced without the date:

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 333 to 335 in abdfb72

	isSyncInProgress && connectionSyncProgress?.stageInProgress
	? translate('workspace.accounting.connections.syncStageName', {stage: connectionSyncProgress.stageInProgress})
	: translate('workspace.accounting.lastSync', {relativeDate: datetimeToRelative}),

What changes do you think we should make in order to solve the problem?

This is QBO case-specific, so we can add a condition in our isConnectionInProgress function, if we see qboConnection?.data but not qboConnection?.config?.credentials, we still want to display the loading indicator.

Let's update isConnectionInProgress function to the following:

function isConnectionInProgress(connectionSyncProgress: OnyxEntry<PolicyConnectionSyncProgress>, policy?: OnyxEntry<Policy>): boolean {
    if (!policy) {
        return false;
    }

    const qboConnection = policy?.connections?.quickbooksOnline;

    const lastSyncProgressDate = parseISO(connectionSyncProgress?.timestamp ?? '');
    return (
        (!!connectionSyncProgress?.stageInProgress &&
            (connectionSyncProgress.stageInProgress !== CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE || !policy?.connections?.[connectionSyncProgress.connectionName]) &&
            isValid(lastSyncProgressDate) &&
            differenceInMinutes(new Date(), lastSyncProgressDate) < CONST.POLICY.CONNECTIONS.SYNC_STAGE_TIMEOUT_MINUTES) ||
// If qboConnection?.data is null and !!qboConnection?.config?.credentials is true, then it's still in progress.
        (!!qboConnection && !qboConnection?.data && !!qboConnection?.config?.credentials)
    );
}

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2024-10-11.at.16.52.59.mov

[hungvu193]

Here's the test branch: https://github.com/hungvu193/App/tree/fix-qbo-syncing

[ishpaul777]

you can still see a split second where we have the connection options missing but the sync has "finished"

@hungvu193 have you been able to reproduce #46445 (comment)

for me the options are visible before the sync is completed 🤔

Screen.Recording.2024-10-12.at.5.00.50.PM.mov

[hungvu193]

Yeah I can still reproduce, you can try with brand new workspace.

[ishpaul777]

Same with new workspace and even new account. options come before "last synced date"

Screen.Recording.2024-10-12.at.10.40.48.PM.mov

[hungvu193]

I think I still can reproduce on latest main