[$250] IOU - Distance tab flickering to manual & back to distance every time when add destination

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a753@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login with gmail account
2. Go to FAB> Submit Expense> Distance
3. Add a start destination> Your location
4. Check tabs (manual, scan, distance) behavior
5. Add stop destination
6. Check tabs (manual, scan, distance) behavior

Expected Result:

Distance tab should remain since we work on that tab

Actual Result:

Distance tab switch to manual and back to distance every time when add destination

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554014_1722020868045.Recording__3602.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7f69f2e00762143
• Upwork Job ID: 1817973479806682768
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @cdOut

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vip

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Christinadobrzyn]

I can reproduce this - only seems to be affecting Android web app. I think this can be external. I think this might be part of Collect since it's a distance expense.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7f69f2e00762143

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[Christinadobrzyn]

waiting on proposals

[Christinadobrzyn]

I'll see if someone at SWM would want this. https://expensify.slack.com/archives/C04878MDF34/p1722447232998509

[cdOut]

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’m going to be working on this task.

[Christinadobrzyn]

Awesome! Thank you @cdOut! I've assigned you to the GH.

[VincentCorleone]

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’m going to be working on this task.

@cdOut So can external contributors submit a proposal and get paid from upwork?

[cdOut]

@VincentCorleone I'm taking over this issue so no, there is no need for proposals.

[cdOut]

I'm still figuring it out, PR should be up today or tomorrow.

[Christinadobrzyn]

Hi, @cdOut, I'm just checking on this to see if you have any specific updates - otherwise, it looks like the PR is in the works!

[cdOut]

No update needed, PR with the patch is being tested by Manan.

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thienlnam]

Just merged the PR, but let's keep this issue open until we get the patch removed with an upstream PR

[Christinadobrzyn]

PR deployed to production yesterday - #47885 so adding the payment date to the subject.

I'm going to be ooo 9/4 - 9/10 so I'll plan on paying this when I'm back - if that's okay.

Do we need a regression?
@mananjadhav are you paid through NewDot?

Payouts due:

• Contributor+: $250 @mananjadhav

[cdOut]

Please check the conversation in the PR itself here, this patch sadly broke another functionality that we didn't catch during testing so we had to revert it.

I'm going to be working on a fix that doesn't break the tab drag changing animation so please keep this issue open until a new PR gets merged.

[cdOut]

Hi, wanted to update this issue. I currently have to focus on other more important issues and I will pick this issue back up early next week.

[mananjadhav]

Thanks for the update @cdOut. Is there someone else who can pick this up? or you'll pick this once you're done with the other PRs?

[cdOut]

I'll pick it up after I'm done with the other PRs.

[Christinadobrzyn]

I'm back - looks like we're working on another PR? @cdOut can you provide the new PR to follow?

[cdOut]

It's not raised yet, I'll let you know when I create it.

[cdOut]

Hi, quick update - I've picked back the issue and I'm searching for a solution that won't affect the side swiping on tabs, should raise a PR for it in the coming days.

[cdOut]

Short update, this is a pretty convoluted issue as fixing the flicker and allowing for the swipe causes another animation in tabs to break so I'm still researching a fix that won't disturb any other parts of the flow.

[Christinadobrzyn]

Just a heads up that I'm going to be ooo until 9/30. I'm not going to assign another BZ teammate since we're working on the fix side of this. If you need anyone please reach out in Slack for a volunteer.

[Christinadobrzyn]

payment summary here - #46346 (comment)

[mananjadhav]

@Christinadobrzyn this was reverted and the follow up PR is still pending. No payment yet on this one.

[cdOut]

I'm going to be raising a follow-up PR with another fix later today.

[mananjadhav]

Thanks for the update @cdOut

[cdOut]

I've found some discrepancies with animations while testing on native devices, will work on correcting it throughout today.

[Christinadobrzyn]

Hi @cdOut do you have an update? Thanks!