[$250] Android - Room - Whisper displays 1 mention when 2 mentions are send in specific way

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4768836
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a room chat
3. Enter [HOLD for payment 2021-09-10] Sign in - Error message is not specific if password is not entered #4856₹&_#7553 and sent the message
4. Note whisper for 2 mentions are shown
5. Enter #gh4h_+&&&-#ehhh & send the message
6. Note whisper for only one mention is shown

Expected Result:

Whisper must display 2 mention when 2 mentions are send

Actual Result:

Whisper displays 1 mention when 2 mentions are send in specific way.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552678_1721913220722.Screenrecorder-2024-07-25-18-36-09-985_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01903b4afb9ff494db
• Upwork Job ID: 1827453197366571253
• Last Price Increase: 2024-09-21
• Automatic offers:
• rojiphil | Reviewer | 104095172
• NJ-2020 | Contributor | 104095173

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

@lanitochka17 does this happen with other combinations of room references? I'm sort of confused because both strings are just one line with no spaces, so I am not sure what is supposed to happen here.

[melvin-bot]

@kevinksullivan, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@kevinksullivan @lanitochka17 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@kevinksullivan, @lanitochka17 Still overdue 6 days?! Let's take care of this!

[kevinksullivan]

Bump @lanitochka17

[lanitochka17]

@kevinksullivan According steps in TR https://expensify.testrail.io/index.php?/tests/view/4768836 step 5 is fail when create whisper with new room.
Expected resault: Verify an actionable whisper asking the user if they want to create the room is triggered.

[lanitochka17]

Issue is still reproducible

az_recorder_20240812_183917_compress_1.mp4

[melvin-bot]

@rojiphil, @slafortune, @kevinksullivan, @lanitochka17 10 days overdue. Is anyone even seeing these? Hello?

[rojiphil]

With that said I think the regex might get too complicated

In that case, we can keep this simple and use @NJ-2020 proposal as that was the first proposal to resolve this issue by adding - to negative lookbehind.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @NJ-2020 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[NJ-2020]

PR ready
cc: @rojiphil

[slafortune]

Going to unassign myself since you are back from OOO @kevinksullivan

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@rojiphil, @Beamanator, @OfstadC, @NJ-2020 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Beamanator]

PR still in review 👍

[melvin-bot]

@rojiphil, @Beamanator, @OfstadC, @NJ-2020 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@rojiphil, @Beamanator, @OfstadC, @NJ-2020 Still overdue 6 days?! Let's take care of this!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

@rojiphil, @Beamanator, @OfstadC, @NJ-2020 10 days overdue. I'm getting more depressed than Marvin.

[Beamanator]

probably can close this out if there's 1 more week of not reproducing?

[melvin-bot]

@rojiphil, @Beamanator, @OfstadC, @NJ-2020 12 days overdue now... This issue's end is nigh!